Changeset 57128 in webkit


Ignore:
Timestamp:
Apr 5, 2010 11:33:02 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-05 Eric Uhrhane <ericu@chromium.org>

Reviewed by Brady Eidson.

window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
https://bugs.webkit.org/show_bug.cgi?id=36671

The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.

No new tests.

  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r57127 r57128  
     12010-04-05  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by Brady Eidson.
     4
     5        window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5
     6        https://bugs.webkit.org/show_bug.cgi?id=36671
     7
     8        The previous "fix" I mistakenly compared hashes, an improvement over comparing pointers, but still not right.
     9
     10        No new tests.
     11
     12        * storage/DatabaseTracker.cpp:
     13        (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Use SecurityOrigin::equal to compare instead of SecurityOriginHash.
     14
    1152010-04-05  Anthony Ricaud  <rik@webkit.org>
    216
  • trunk/WebCore/storage/DatabaseTracker.cpp

    r57036 r57128  
    235235
    236236    for (HashSet<ProposedDatabase*>::iterator iter = m_proposedDatabases.begin(); iter != m_proposedDatabases.end(); ++iter)
    237         if ((*iter)->second.name() == name && SecurityOriginHash::hash((*iter)->first) == SecurityOriginHash::hash(origin))
     237        if ((*iter)->second.name() == name && (*iter)->first->equal(origin))
    238238            return String();
    239239
Note: See TracChangeset for help on using the changeset viewer.