Changeset 57177 in webkit

Timestamp:

Apr 6, 2010 4:27:01 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-06 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
​https://bugs.webkit.org/show_bug.cgi?id=37145

The timeout on this test is wrong because the helper library assumes
that we're only going to do one transition, but the test actually does
two in sequence. This patch doubles the timeout to account for that.

The design of these tests are quite unfortunate because these timeout
behaviors don't seem like they'd be reliable on slow machines like
Tiger. I'm not 100% convinced that this will fix the flakiness, but it
seems like an improvement.

I'll file a separate bug about DRT leaking state from one test to
another.

• transitions/transition-end-event-helpers.js:
• transitions/transition-end-event-set-none.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• transitions/transition-end-event-helpers.js (modified) (1 diff)
• transitions/transition-end-event-set-none.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-06  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Alexey Proskuryakov.
+
+        transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
+        https://bugs.webkit.org/show_bug.cgi?id=37145
+
+        The timeout on this test is wrong because the helper library assumes
+        that we're only going to do one transition, but the test actually does
+        two in sequence.  This patch doubles the timeout to account for that.
+
+        The design of these tests are quite unfortunate because these timeout
+        behaviors don't seem like they'd be reliable on slow machines like
+        Tiger.  I'm not 100% convinced that this will fix the flakiness, but it
+        seems like an improvement.
+
+        I'll file a separate bug about DRT leaking state from one test to
+        another.
+
+        * transitions/transition-end-event-helpers.js:
+        * transitions/transition-end-event-set-none.html:
+
 2010-04-06  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
 

trunk/LayoutTests/transitions/transition-end-event-helpers.js

@@ -135 +135 @@
   }
 
-  function startTest(expected, callback)
+  function startTest(expected, callback, maxTime)
   {
     if (callback)
       callback();
     
-    var maxTime = 0;
+    if (!maxTime)
+        maxTime = 0;
 
     for (var i=0; i < expected.length; ++i) {

trunk/LayoutTests/transitions/transition-end-event-set-none.html

@@ -52 +52 @@
     }
     
-    runTransitionTest(expectedEndEvents, setupTest);
+    // We need to pass an explicit maxTime because we use two sequential
+    // transitions that each take 0.2s.
+    runTransitionTest(expectedEndEvents, setupTest, 0.5);
     
   </script>