Changeset 57193 in webkit

Timestamp:

Apr 6, 2010 9:58:29 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-06 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Remove obsolete MOBILE flag
​https://bugs.webkit.org/show_bug.cgi?id=37125

The MOBILE flag is no longer used by any of the ports.
The flag use to control some tokenizer defaults that
can be changed runtime.

No new tests as there is no new functionality.

• config.h:
• html/HTMLTokenizer.cpp:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• config.h (modified) (1 diff)
• html/HTMLTokenizer.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Remove obsolete MOBILE flag
+        https://bugs.webkit.org/show_bug.cgi?id=37125
+
+        The MOBILE flag is no longer used by any of the ports.
+        The flag use to control some tokenizer defaults that 
+        can be changed runtime.
+
+        No new tests as there is no new functionality.
+
+        * config.h:
+        * html/HTMLTokenizer.cpp:
+
 2010-04-06  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/config.h

@@ -43 +43 @@
 #define WEBKIT_EXPORTDATA
 #endif
-
-#define MOBILE 0
 
 #ifdef __APPLE__

trunk/WebCore/html/HTMLTokenizer.cpp

@@ -68 +68 @@
 using namespace HTMLNames;
 
-#if MOBILE
-// The mobile device needs to be responsive, as such the tokenizer chunk size is reduced.
 // This value is used to define how many characters the tokenizer will process before 
 // yeilding control.
-static const int defaultTokenizerChunkSize = 256;
-#else
+// To increase responsivness reduce the tokenizer chunk size.
 static const int defaultTokenizerChunkSize = 4096;
-#endif
-
-#if MOBILE
-// As the chunks are smaller (above), the tokenizer should not yield for as long a period, otherwise
-// it will take way to long to load a page.
-static const double defaultTokenizerTimeDelay = 0.300;
-#else
+
 // FIXME: We would like this constant to be 200ms.
 // Yielding more aggressively results in increased responsiveness and better incremental rendering.
 // It slows down overall page-load on slower machines, though, so for now we set a value of 500.
+// For smaller chunks (above) decrease the value of TimerDelay as the the tokenizer should not 
+// yield for as long a period otherwise it will take way to long to load a page.
 static const double defaultTokenizerTimeDelay = 0.500;
-#endif
 
 static const char commentStart [] = "<!--";