Changeset 57202 in webkit
- Timestamp:
- Apr 7, 2010 4:14:59 AM (14 years ago)
- Location:
- trunk/WebKit/qt
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKit/qt/ChangeLog
r57155 r57202 1 2010-04-07 Andreas Kling <andreas.kling@nokia.com> 2 3 Reviewed by Simon Hausmann. 4 5 [Qt] When providing a widget for the PDF mime type it will cause a crash 6 7 m_pluginView may actually be a Widget (for embedded Qt widgets), 8 so always check isPluginView() before calling PluginView specific methods. 9 10 https://bugs.webkit.org/show_bug.cgi?id=29450 11 12 * WebCoreSupport/FrameLoaderClientQt.cpp: 13 (WebCore::FrameLoaderClientQt::finishedLoading): 14 (WebCore::FrameLoaderClientQt::setMainDocumentError): 15 (WebCore::FrameLoaderClientQt::committedLoad): 16 1 17 2010-04-06 Diego Gonzalez <diego.gonzalez@openbossa.org> 2 18 -
trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
r56750 r57202 518 518 } 519 519 else { 520 m_pluginView->didFinishLoading(); 520 if (m_pluginView->isPluginView()) 521 m_pluginView->didFinishLoading(); 521 522 m_pluginView = 0; 522 523 m_hasSentResponseToPlugin = false; … … 707 708 } 708 709 } else { 709 m_pluginView->didFail(error); 710 if (m_pluginView->isPluginView()) 711 m_pluginView->didFail(error); 710 712 m_pluginView = 0; 711 713 m_hasSentResponseToPlugin = false; … … 727 729 728 730 // We re-check here as the plugin can have been created 729 if (m_pluginView ) {731 if (m_pluginView && m_pluginView->isPluginView()) { 730 732 if (!m_hasSentResponseToPlugin) { 731 733 m_pluginView->didReceiveResponse(loader->response());
Note: See TracChangeset
for help on using the changeset viewer.