Changeset 57243 in webkit


Ignore:
Timestamp:
Apr 7, 2010 5:32:01 PM (14 years ago)
Author:
ojan@chromium.org
Message:

2010-04-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r57178.
http://trac.webkit.org/changeset/57178
https://bugs.webkit.org/show_bug.cgi?id=37240

Caused chromium browser_test and ui_test regressions
(Requested by ojan on #webkit).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
Location:
trunk
Files:
2 deleted
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r57239 r57243  
     12010-04-07  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r57178.
     4        http://trac.webkit.org/changeset/57178
     5        https://bugs.webkit.org/show_bug.cgi?id=37240
     6
     7        Caused chromium browser_test and ui_test regressions
     8        (Requested by ojan on #webkit).
     9
     10        * bindings/v8/ScriptController.cpp:
     11        (WebCore::ScriptController::processingUserGesture):
     12
    1132010-04-07  Jian Li  <jianli@chromium.org>
    214
  • trunk/WebCore/bindings/v8/ScriptController.cpp

    r57178 r57243  
    193193            return true;
    194194    } else if (m_sourceURL && m_sourceURL->isNull() && !activeProxy->timerCallback()) {
    195         // This is the javascript:window.open('...') case -> we let it through if it was a <a href> user click and not if it was window.open().
    196         return UserGestureIndicator::processingUserGesture();
     195        // This is the <a href="javascript:window.open('...')> case -> we let it through.
     196        return true;
    197197    }
    198198
Note: See TracChangeset for help on using the changeset viewer.