Changeset 57252 in webkit

Timestamp:

Apr 7, 2010 11:51:00 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
​https://bugs.webkit.org/show_bug.cgi?id=37145

I think this test might be getting confused because it only expects the
end event to fire once but actually it fires again for the second
transition. Let's try this patch and see if it fixes the flakiness.

• transitions/transition-end-event-set-none.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• transitions/transition-end-event-set-none.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-07  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        transitions/transition-end-event-transform.html fails intermittently on Tiger Intel Release bot
+        https://bugs.webkit.org/show_bug.cgi?id=37145
+
+        I think this test might be getting confused because it only expects the
+        end event to fire once but actually it fires again for the second
+        transition.  Let's try this patch and see if it fixes the flakiness.
+
+        * transitions/transition-end-event-set-none.html:
+
 2010-04-07  Eric Seidel  <eric@webkit.org>
 

trunk/LayoutTests/transitions/transition-end-event-set-none.html

@@ -37 +37 @@
     }
     
+    var firstTimeInHandleEndEvent = true;
     function handleEndEvent(event)
     {
@@ -42 +43 @@
       
       event.target.style.webkitTransitionProperty = "none";
-      window.setTimeout(startTransition, 100);
+      if (firstTimeInHandleEndEvent) {
+        firstTimeInHandleEndEvent = false;
+        window.setTimeout(startTransition, 100);
+      }
     }