Changeset 57253 in webkit

Timestamp:

Apr 7, 2010 11:55:49 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests crashes when run on a 64-bit machine
​https://bugs.webkit.org/show_bug.cgi?id=37248

• Scripts/webkitpy/layout_tests/port/mac.py:
  • The code was trying to always run the 32-bit intel version of the DumpRenderTree binary. DRT does not build 32-bit on 64-bit machines so that makes no sense. This may have made sense for test_shell at some point, but I think we should just remove this for DRT.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-07  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        new-run-webkit-tests crashes when run on a 64-bit machine
+        https://bugs.webkit.org/show_bug.cgi?id=37248
+
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+         - The code was trying to always run the 32-bit intel version
+           of the DumpRenderTree binary.  DRT does not build 32-bit on 64-bit
+           machines so that makes no sense.  This may have made sense for test_shell
+           at some point, but I think we should just remove this for DRT.
+
 2010-04-07  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -407 +407 @@
             cmd += self._options.wrapper.split()
 
-        cmd += ['arch', '-i386', port._path_to_driver(), '-']
+        cmd += [port._path_to_driver(), '-']
 
         if image_path: