Changeset 57254 in webkit

Timestamp:

Apr 7, 2010 11:56:46 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-07 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove depricated op.popen2 call in new-run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=37249

Python complains that this API is depricated. We already solved this
problem in executive.py.

• Scripts/webkitpy/layout_tests/port/mac.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-07  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove depricated op.popen2 call in new-run-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=37249
+
+        Python complains that this API is depricated.  We already solved this
+        problem in executive.py.
+
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+
 2010-04-07  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -166 +166 @@
 
     def num_cores(self):
-        ncores = int(os.popen2("sysctl -n hw.ncpu")[1].read())
+        ncores = int(executive.run_command(["sysctl", "-n", "hw.ncpu"]))
         # FIXME: new-run-webkit-tests is unstable running more than four
         # threads in parallel.