Changeset 57326 in webkit


Ignore:
Timestamp:
Apr 9, 2010 3:53:00 AM (14 years ago)
Author:
mrowe@apple.com
Message:

<http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again

Reviewed by Oliver Hunt.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Wire up the script. Remove the three inappropriate

files from the Copy Bundle Resources build phase.

WebKitTools:

Add a script to detect the presence of inappropriate files in the frameworks. At present
it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
as these are the only cases we've encountered recently. It can be extended to check the
other frameworks or for other inappropriate files in the future.

  • Scripts/check-for-inappropriate-files-in-framework: Added.
Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r57324 r57326  
     12010-04-09  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        <http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again
     6
     7        * WebCore.xcodeproj/project.pbxproj: Wire up the script.  Remove the three inappropriate
     8        files from the Copy Bundle Resources build phase.
     9
    1102010-04-09  Zhenyao Mo  <zmo@google.com>
    211
  • trunk/WebCore/WebCore.xcodeproj/project.pbxproj

    r57292 r57326  
    597597                2D9066060BE141D400956998 /* LayoutState.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D9066040BE141D400956998 /* LayoutState.cpp */; };
    598598                2D9066070BE141D400956998 /* LayoutState.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D9066050BE141D400956998 /* LayoutState.h */; settings = {ATTRIBUTES = (Private, ); }; };
    599                 2E0888C4114883A900AF4265 /* DOMFormData.idl in Resources */ = {isa = PBXBuildFile; fileRef = 2E0888C3114883A900AF4265 /* DOMFormData.idl */; };
    600599                2E0888D41148848A00AF4265 /* JSDOMFormData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2E0888D21148848A00AF4265 /* JSDOMFormData.cpp */; };
    601600                2E0888D51148848A00AF4265 /* JSDOMFormData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2E0888D31148848A00AF4265 /* JSDOMFormData.h */; };
     
    25112510                A4226E961163D73A008B8397 /* DOMHTMLProgressElement.mm in Sources */ = {isa = PBXBuildFile; fileRef = A4226E931163D73A008B8397 /* DOMHTMLProgressElement.mm */; };
    25122511                A4226E991163D7CC008B8397 /* DOMHTMLProgressElementInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = A4226E981163D7CC008B8397 /* DOMHTMLProgressElementInternal.h */; };
    2513                 A4226EA61163D84D008B8397 /* HTMLProgressElement.idl in Resources */ = {isa = PBXBuildFile; fileRef = A4226EA51163D84D008B8397 /* HTMLProgressElement.idl */; };
    25142512                A43BF5981149290A00C643CA /* HTMLProgressElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A43BF5961149290A00C643CA /* HTMLProgressElement.cpp */; };
    25152513                A43BF5991149290A00C643CA /* HTMLProgressElement.h in Headers */ = {isa = PBXBuildFile; fileRef = A43BF5971149290A00C643CA /* HTMLProgressElement.h */; };
     
    49204918                FA5FAE4211126A5D00D3750F /* RenderMathMLOperator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FA5FAE4011126A5D00D3750F /* RenderMathMLOperator.cpp */; };
    49214919                FA5FAE4311126A5D00D3750F /* RenderMathMLOperator.h in Headers */ = {isa = PBXBuildFile; fileRef = FA5FAE4111126A5D00D3750F /* RenderMathMLOperator.h */; };
    4922                 FA654A641108ABB7002615E0 /* mathml.css in Resources */ = {isa = PBXBuildFile; fileRef = FA654A631108ABB7002615E0 /* mathml.css */; };
    4923                 FA654A681108ABE2002615E0 /* mathattrs.in in Resources */ = {isa = PBXBuildFile; fileRef = FA654A671108ABE2002615E0 /* mathattrs.in */; };
    49244920                FA654A6B1108ABED002615E0 /* MathMLTextElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = FA654A691108ABED002615E0 /* MathMLTextElement.cpp */; };
    49254921                FA654A6C1108ABED002615E0 /* MathMLTextElement.h in Headers */ = {isa = PBXBuildFile; fileRef = FA654A6A1108ABED002615E0 /* MathMLTextElement.h */; };
     
    1885218848                                933457E60EBFDF6B00B80894 /* Check For Exit Time Destructors */,
    1885318849                                5D0D540D0E9862F60029E223 /* Check For Weak VTables and Externals */,
     18850                                5DF50887116F3077005202AB /* Check For Inappropriate Files In Framework */,
    1885418851                        );
    1885518852                        buildRules = (
     
    1890918906                                85136C9C0AED665900F90A3D /* linkCursor.png in Resources */,
    1891018907                                1CDC14050DD3934C006EACD3 /* localizedStrings.js in Resources */,
    18911                                 FA654A681108ABE2002615E0 /* mathattrs.in in Resources */,
    18912                                 FA654A641108ABB7002615E0 /* mathml.css in Resources */,
    1891318908                                AB4261D80A2F6C9700BDD17D /* missingImage.tiff in Resources */,
    1891418909                                85136C9D0AED665900F90A3D /* moveCursor.png in Resources */,
     
    1893218927                                1AB1AE7A0C051FDE00139F4F /* zoomInCursor.png in Resources */,
    1893318928                                1AB1AE7B0C051FDE00139F4F /* zoomOutCursor.png in Resources */,
    18934                                 2E0888C4114883A900AF4265 /* DOMFormData.idl in Resources */,
    18935                                 A4226EA61163D84D008B8397 /* HTMLProgressElement.idl in Resources */,
    1893618929                        );
    1893718930                        runOnlyForDeploymentPostprocessing = 0;
     
    1901819011                        shellPath = /bin/sh;
    1901919012                        shellScript = "# Touch Info.plist to let Xcode know it needs to copy it into the built product\nif [[ \"${CONFIGURATION}\" != \"Production\" ]]; then\n    touch \"$SRCROOT/Info.plist\";\nfi;\n";
     19013                };
     19014                5DF50887116F3077005202AB /* Check For Inappropriate Files In Framework */ = {
     19015                        isa = PBXShellScriptBuildPhase;
     19016                        buildActionMask = 2147483647;
     19017                        files = (
     19018                        );
     19019                        inputPaths = (
     19020                        );
     19021                        name = "Check For Inappropriate Files In Framework";
     19022                        outputPaths = (
     19023                        );
     19024                        runOnlyForDeploymentPostprocessing = 0;
     19025                        shellPath = /bin/sh;
     19026                        shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\n    exit 0;\nfi\n\nif [ -f ../WebKitTools/Scripts/check-for-inappropriate-files-in-framework ]; then\n    ../WebKitTools/Scripts/check-for-inappropriate-files-in-framework || exit $?\nfi\n";
    1902019027                };
    1902119028                933457E60EBFDF6B00B80894 /* Check For Exit Time Destructors */ = {
  • trunk/WebKitTools/ChangeLog

    r57312 r57326  
     12010-04-09  Mark Rowe  <mrowe@apple.com>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        <http://webkit.org/b/37326> IDL files are being copied in to the WebCore framework again
     6
     7        Add a script to detect the presence of inappropriate files in the frameworks.  At present
     8        it only looks for .css, .idl and .in files in the top level of WebCore.framework/Resources,
     9        as these are the only cases we've encountered recently.  It can be extended to check the
     10        other frameworks or for other inappropriate files in the future.
     11
     12        * Scripts/check-for-inappropriate-files-in-framework: Added.
     13
    1142010-04-08  Sam Weinig  <sam@webkit.org>
    215
Note: See TracChangeset for help on using the changeset viewer.