Changeset 57333 in webkit

Timestamp:

Apr 9, 2010 5:12:27 AM (14 years ago)

Author:

Simon Hausmann

Message:

[Qt] Symbian apps crash on exit due to a bad qObject_cast.

Patch by David Leong <​david.leong@nokia.com> on 2010-04-09
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=37303

Added check for NULL to avoid the crash.

• plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformDestroy):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/symbian/PluginViewSymbian.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-09  David Leong  <david.leong@nokia.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Symbian apps crash on exit due to a bad qObject_cast.
+
+        https://bugs.webkit.org/show_bug.cgi?id=37303
+
+        Added check for NULL to avoid the crash.
+
+        * plugins/symbian/PluginViewSymbian.cpp:
+        (WebCore::PluginView::platformDestroy):
+
 2010-04-09  Mark Rowe  <mrowe@apple.com>
 

trunk/WebCore/plugins/symbian/PluginViewSymbian.cpp

@@ -416 +416 @@
 {
     QWebPageClient* client = m_parentFrame->view()->hostWindow()->platformPageClient();
-    if (QGraphicsWebView *webView = qobject_cast<QGraphicsWebView*>(client->pluginParent()))
+    if (client && qobject_cast<QGraphicsWebView*>(client->pluginParent()))
         delete static_cast<PluginContainerSymbian*>(platformPluginWidget())->proxy();
     else