Changeset 57335 in webkit

Timestamp:

Apr 9, 2010 6:13:45 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-09 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
Should not try to access WebViewClient if the frame has already been disconnected.
​https://bugs.webkit.org/show_bug.cgi?id=37318

• src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebGeolocationServiceBridgeImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-09  Marcus Bulach  <bulach@chromium.org>
+
+        Reviewed by Jeremy Orlow.
+
+        Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
+        Should not try to access WebViewClient if the frame has already been disconnected.
+        https://bugs.webkit.org/show_bug.cgi?id=37318
+
+        * src/WebGeolocationServiceBridgeImpl.cpp:
+        (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
+
 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
 

trunk/WebKit/chromium/src/WebGeolocationServiceBridgeImpl.cpp

@@ -125 +125 @@
 void WebGeolocationServiceBridgeImpl::stopUpdating()
 {
-    if (m_bridgeId) {
-        WebGeolocationService* geolocationService = getWebViewClient()->geolocationService();
+    WebViewClient* webViewClient = getWebViewClient();
+    if (m_bridgeId && webViewClient) {
+        WebGeolocationService* geolocationService = webViewClient->geolocationService();
         geolocationService->stopUpdating(m_bridgeId);
         geolocationService->detachBridge(m_bridgeId);
-        m_bridgeId = 0;
     }
+    m_bridgeId = 0;
 }