Changeset 57338 in webkit

Timestamp:

Apr 9, 2010 7:01:15 AM (14 years ago)

Author:

xan@webkit.org

Message:

2010-04-09 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

WebGtk GLib-CRITICAL Segmentation fault
​https://bugs.webkit.org/show_bug.cgi?id=34937

Do not crash if a plugin does not return anything in
NP_GetMIMEDescription. This can happen, and other ports gracefully
handle the situation.

• plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/gtk/PluginPackageGtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-09  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        WebGtk GLib-CRITICAL Segmentation fault
+        https://bugs.webkit.org/show_bug.cgi?id=34937
+
+        Do not crash if a plugin does not return anything in
+        NP_GetMIMEDescription. This can happen, and other ports gracefully
+        handle the situation.
+
+        * plugins/gtk/PluginPackageGtk.cpp:
+        (WebCore::PluginPackage::fetchInfo):
+
 2010-04-09  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/plugins/gtk/PluginPackageGtk.cpp

@@ -70 +70 @@
 
     const gchar* types = NP_GetMIMEDescription();
+    if (!types)
+        return true;
+
     gchar** mimeDescs = g_strsplit(types, ";", -1);
     for (int i = 0; mimeDescs[i] && mimeDescs[i][0]; i++) {