Changeset 57398 in webkit

Timestamp:

Apr 9, 2010 7:17:07 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
​https://bugs.webkit.org/show_bug.cgi?id=37376

We need to explicitly pass the --release flag. I bet there are more
instances of this bug.

• Scripts/webkitpy/layout_tests/port/base.py:
• Scripts/webkitpy/layout_tests/port/mac.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/base.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-09  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        new-run-webkit-tests --release fails to build release DRT when global configuration is Debug
+        https://bugs.webkit.org/show_bug.cgi?id=37376
+
+        We need to explicitly pass the --release flag.  I bet there are more
+        instances of this bug.
+
+        * Scripts/webkitpy/layout_tests/port/base.py:
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+
 2010-04-09  Tony Chang  <tony@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py

@@ -51 +51 @@
     """Abstract class for Port-specific hooks for the layout_test package.
     """
+
+    @staticmethod
+    def flag_from_configuration(configuration):
+        flags_by_configuration = {
+            "Debug": "--debug",
+            "Release": "--release",
+        }
+        return flags_by_configuration[configuration]
 
     def __init__(self, port_name=None, options=None):

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -82 +82 @@
 
     def check_build(self, needs_http):
-        build_drt_command = [self.script_path("build-dumprendertree")]
-        if self._options.configuration == "Debug":
-            build_drt_command.append('--debug')
+        build_drt_command = [
+            self.script_path("build-dumprendertree"),
+            self.flag_from_configuration(self._options.configuration),
+        ]
         if executive.run_command(build_drt_command, return_exit_code=True):
             return False