Changeset 57402 in webkit

Timestamp:

Apr 9, 2010 7:50:04 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-09 Evan Stade <​estade@chromium.org>

Reviewed by Eric Seidel.

[chromium] Linux: respect the scale factor during printing
​https://bugs.webkit.org/show_bug.cgi?id=37168

Chromium doesn't support testing .pdfs from printing at the moment, so
this change is not covered by any tests.

• src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::spoolPage):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebFrameImpl.cpp (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-09  Evan Stade  <estade@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        [chromium] Linux: respect the scale factor during printing
+        https://bugs.webkit.org/show_bug.cgi?id=37168
+
+        Chromium doesn't support testing .pdfs from printing at the moment, so
+        this change is not covered by any tests.
+
+        * src/WebFrameImpl.cpp:
+        (WebKit::ChromePrintContext::spoolPage):
+
 2010-04-09  Aaron Boodman  <aa@chromium.org>
 

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -289 +289 @@
     }
 
-    // Spools the printed page, a subrect of m_frame.  Skip the scale step.
+    // Spools the printed page, a subrect of m_frame. Skip the scale step.
     // NativeTheme doesn't play well with scaling. Scaling is done browser side
-    // instead.  Returns the scale to be applied.
+    // instead. Returns the scale to be applied.
+    // On Linux, we don't have the problem with NativeTheme, hence we let WebKit
+    // do the scaling and ignore the return value.
     virtual float spoolPage(GraphicsContext& ctx, int pageNumber)
     {
@@ -298 +300 @@
 
         ctx.save();
+#if OS(LINUX)
+        ctx.scale(WebCore::FloatSize(scale, scale));
+#endif
         ctx.translate(static_cast<float>(-pageRect.x()),
                       static_cast<float>(-pageRect.y()));