Changeset 57425 in webkit


Ignore:
Timestamp:
Apr 10, 2010 4:39:33 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-04-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out the win port for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=37393

I haven't tried running this yet, but we've got to start somewhere.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py: Added.
Location:
trunk/WebKitTools
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r57424 r57425  
     12010-04-10  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Sketch out the win port for new-run-webkit-tests
     6        https://bugs.webkit.org/show_bug.cgi?id=37393
     7
     8        I haven't tried running this yet, but we've got to start somewhere.
     9
     10        * Scripts/webkitpy/layout_tests/port/factory.py:
     11        * Scripts/webkitpy/layout_tests/port/mac.py:
     12        * Scripts/webkitpy/layout_tests/port/webkit.py:
     13        * Scripts/webkitpy/layout_tests/port/win.py: Added.
     14
    1152010-04-10  Ojan Vafai  <ojan@chromium.org>
    216
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/factory.py

    r56005 r57425  
    4141    if port_to_use is None:
    4242        if sys.platform == 'win32':
    43             port_to_use = 'chromium-win'
     43            if options and hasattr(options, 'chromium') and options.chromium:
     44                port_to_use = 'chromium-win'
     45            else:
     46                port_to_use = 'win'
    4447        elif sys.platform == 'linux2':
    4548            port_to_use = 'chromium-linux'
     
    6366        import mac
    6467        return mac.MacPort(port_name, options)
     68    elif port_to_use.startswith('win'):
     69        import win
     70        return win.WinPort(port_name, options)
    6571    elif port_to_use.startswith('chromium-mac'):
    6672        import chromium_mac
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

    r57423 r57425  
    1 #!/usr/bin/env python
    21# Copyright (C) 2010 Google Inc. All rights reserved.
    32#
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py

    r57423 r57425  
    6666
    6767    def baseline_search_path(self):
    68         raise NotImplementedError('WebKitPort.baseline_search_path')
     68        return [self._webkit_baseline_path(self._name)]
     69
     70    def path_to_test_expectations_file(self):
     71        return os.path.join(self._webkit_baseline_path(self._name),
     72                            'test_expectations.txt')
    6973
    7074    def _build_driver(self):
     
    168172        return result
    169173
    170     def path_to_test_expectations_file(self):
    171         raise NotImplementedError('WebKitPort.path_to_test_expectations_file')
    172 
    173174    def results_directory(self):
    174175        # FIXME: Why do we say chromium here?  Maybe "new-run-webkit-tests-"?
     
    191192        # At the moment we don't use test platform names, but we have
    192193        # to return something.
    193         return ('mac',)
     194        return ('mac', 'win')
    194195
    195196    def _tests_for_other_platforms(self):
     
    241242        return tests_to_skip
    242243
     244    def _skipped_file_paths(self):
     245        return [os.path.join(self._webkit_baseline_path(self._name,
     246                                                            'Skipped'))]
     247
    243248    def _expectations_from_skipped_files(self):
    244249        tests_to_skip = []
     
    278283
    279284    def test_platform_name(self):
    280         raise NotImplementedError('WebKitPort.test_platform_name')
     285        return self._name + self.version()
    281286
    282287    def test_platform_names(self):
Note: See TracChangeset for help on using the changeset viewer.