Changeset 57434 in webkit

Timestamp:

Apr 10, 2010 8:51:59 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
​https://bugs.webkit.org/show_bug.cgi?id=37400

Add an empty test expectations file. I'm not sure whether we'll use
this one or make a common one for each port. However, as written, this
file is requires to run new-run-webkit-tests on Windows.

• platform/win/test_expectations.txt: Added.

2010-04-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix bugs to make new-run-webkit-tests almost run on windows
​https://bugs.webkit.org/show_bug.cgi?id=37400

Fix some minor bugs that prevent new-run-webkit-tests from being run on
Windows. I still haven't run it to completion, but I'm getting
further.

• Scripts/webkitpy/layout_tests/port/factory.py:
• Scripts/webkitpy/layout_tests/port/webkit.py:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/test_expectations.txt (added)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/Scripts/webkitpy/layout_tests/port/factory.py (modified) (1 diff)
• WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix bugs to make new-run-webkit-tests almost run on windows
+        https://bugs.webkit.org/show_bug.cgi?id=37400
+
+        Add an empty test expectations file.  I'm not sure whether we'll use
+        this one or make a common one for each port.  However, as written, this
+        file is requires to run new-run-webkit-tests on Windows.
+
+        * platform/win/test_expectations.txt: Added.
+
 2010-04-10  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix bugs to make new-run-webkit-tests almost run on windows
+        https://bugs.webkit.org/show_bug.cgi?id=37400
+
+        Fix some minor bugs that prevent new-run-webkit-tests from being run on
+        Windows.  I still haven't run it to completion, but I'm getting
+        further.
+
+        * Scripts/webkitpy/layout_tests/port/factory.py:
+        * Scripts/webkitpy/layout_tests/port/webkit.py:
+
 2010-04-10  Robert Hogan  <robert@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -40 +40 @@
     port_to_use = port_name
     if port_to_use is None:
-        if sys.platform == 'win32':
+        if sys.platform == 'win32' or sys.platform == 'cygwin':
             if options and hasattr(options, 'chromium') and options.chromium:
                 port_to_use = 'chromium-win'

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py

@@ -243 +243 @@
 
     def _skipped_file_paths(self):
-        return [os.path.join(self._webkit_baseline_path(self._name,
-                                                            'Skipped'))]
+        return [os.path.join(self._webkit_baseline_path(self._name),
+                                                        'Skipped')]
 
     def _expectations_from_skipped_files(self):