Changeset 57476 in webkit


Ignore:
Timestamp:
Apr 12, 2010 11:42:48 AM (14 years ago)
Author:
hyatt@apple.com
Message:

​https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.

Reviewed by Sam Weinig.

WebCore:

Added fast/history/multiple-classes-visited.html.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):

LayoutTests:

  • fast/history/multiple-classes-visited-expected.txt: Added.
  • fast/history/multiple-classes-visited.html: Added.
Location:
trunk
Files:
2 added
1 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r57473 r57476  
     12010-04-12  David Hyatt  <hyatt@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.
     6
     7        * fast/history/multiple-classes-visited-expected.txt: Added.
     8        * fast/history/multiple-classes-visited.html: Added.
     9
    1102010-04-12  Jeff Schiller  <codedread@gmail.com>
    211

  • trunk/LayoutTests/platform/win/Skipped

    r57464 r57476  
    697697fast/history/back-forward-reset-after-error-handling.html
    698698
     699# Need to implement computedStyleWithVisitedInfo
     700fast/history/multiple-classes-visited.html
     701fast/history/nested-visited-test.html
     702fast/history/self-is-visited.html
     703fast/history/sibling-visited-test.html
     704
    699705# ACCELERATED_COMPOSITING tests that crash
    700706compositing/layers-inside-overflow-scroll.html

  • trunk/WebCore/ChangeLog

    r57474 r57476  
     12010-04-12  David Hyatt  <hyatt@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.
     6
     7        Added fast/history/multiple-classes-visited.html.
     8
     9        * css/CSSStyleSelector.cpp:
     10        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
     11
    1122010-04-12  Dirk Schulze  <krit@webkit.org>
    213

  • trunk/WebCore/css/CSSStyleSelector.cpp

    r57299 r57476  
    920920{
    921921    PseudoId dynamicPseudo = NOPSEUDO;
    922 
    923     return checkSelector(sel, element, 0, dynamicPseudo, true, false) == SelectorMatches;
     922    return checkSelector(sel, element, 0, dynamicPseudo, false, false) == SelectorMatches;
    924923}
    925924
    … …  
    18301829
    18311830    // Check for nested links.
    1832     if (m_matchVisitedPseudoClass) {
     1831    if (m_matchVisitedPseudoClass && !isSubSelector) {
    18331832        RenderStyle* currentStyle = elementStyle ? elementStyle : e->renderStyle();
    18341833        if (currentStyle && currentStyle->insideLink() && e->isLink()) {
Note: See TracChangeset for help on using the changeset viewer.