Changeset 57550 in webkit

Timestamp:

Apr 13, 2010 4:54:42 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding a sanity check.

Add check to make sure commit-queue can never commit too short a message
​https://bugs.webkit.org/show_bug.cgi?id=37528

The commit-queue made bogus messages here:
​http://trac.webkit.org/changeset/57532
​http://trac.webkit.org/changeset/57534

This was a regression caused by adding unicode parsing for
our ChangeLog files. Popen does not seem to play nice with
unicode strings.

I'm also adding an "assert" to make sure short ChangeLogs never happen again.

• Scripts/webkitpy/common/system/executive.py:
  • Cast input to strings before passing to POpen
• Scripts/webkitpy/tool/steps/commit.py:
  • Validate that commit messages are not to short.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/executive.py (modified) (1 diff)
• Scripts/webkitpy/tool/steps/commit.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-13  Eric Seidel  <eric@webkit.org>
+
+        Unreviewed, just adding a sanity check.
+
+        Add check to make sure commit-queue can never commit too short a message
+        https://bugs.webkit.org/show_bug.cgi?id=37528
+
+        The commit-queue made bogus messages here:
+        http://trac.webkit.org/changeset/57532
+        http://trac.webkit.org/changeset/57534
+
+        This was a regression caused by adding unicode parsing for
+        our ChangeLog files.  Popen does not seem to play nice with
+        unicode strings.
+
+        I'm also adding an "assert" to make sure short ChangeLogs never happen again.
+
+        * Scripts/webkitpy/common/system/executive.py:
+         - Cast input to strings before passing to POpen
+        * Scripts/webkitpy/tool/steps/commit.py:
+         - Validate that commit messages are not to short.
+
 2010-04-13  Adam Roben  <aroben@apple.com>
 

trunk/WebKitTools/Scripts/webkitpy/common/system/executive.py

@@ -180 +180 @@
             if input:
                 stdin = subprocess.PIPE
-            string_to_communicate = input
+            # string_to_communicate seems to need to be a str for proper
+            # communication with shell commands.
+            # See https://bugs.webkit.org/show_bug.cgi?id=37528
+            # For an example of a regresion caused by passing a unicode string through.
+            string_to_communicate = str(input)
         if return_stderr:
             stderr = subprocess.STDOUT

trunk/WebKitTools/Scripts/webkitpy/tool/steps/commit.py

@@ -33 +33 @@
     def run(self, state):
         commit_message = self._tool.checkout().commit_message_for_this_commit()
+        if len(commit_message.message()) < 50:
+            raise Exception("Attempted to commit with a commit message shorter than 50 characters.  Either your patch is missing a ChangeLog or webkit-patch may have a bug.")
         state["commit_text"] =  self._tool.scm().commit_with_message(commit_message.message())