Changeset 57625 in webkit

Timestamp:

Apr 14, 2010 7:58:12 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-14 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix memory leak inside QScriptEnginePrivate::makeJSValue.

QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.

[Qt] tst_QScriptValue::toString has a memory leak.
​https://bugs.webkit.org/show_bug.cgi?id=37598

• qt/api/qscriptengine_p.h: (QScriptEnginePrivate::makeJSValue):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• qt/api/qscriptengine_p.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-04-14  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Fix memory leak inside QScriptEnginePrivate::makeJSValue.
+
+        QScriptEnginePrivate::makeJSValue should release temporary JSStringRef variable.
+
+        [Qt] tst_QScriptValue::toString has a memory leak.
+        https://bugs.webkit.org/show_bug.cgi?id=37598
+
+        * qt/api/qscriptengine_p.h:
+        (QScriptEnginePrivate::makeJSValue):
+
 2010-04-14  Peter Varga  <pvarga@inf.u-szeged.hu>
 

trunk/JavaScriptCore/qt/api/qscriptengine_p.h

@@ -105 +105 @@
 JSValueRef QScriptEnginePrivate::makeJSValue(const QString& string) const
 {
-    return JSValueMakeString(m_context, QScriptConverter::toString(string));
+    JSStringRef tmp = QScriptConverter::toString(string);
+    JSValueRef result = JSValueMakeString(m_context, tmp);
+    JSStringRelease(tmp);
+    return result;
 }