Changeset 57631 in webkit


Ignore:
Timestamp:
Apr 14, 2010 9:04:50 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
  • page/ChromeClient.h: (WebCore::ChromeClient::isWindowed): (WebCore::ChromeClient::isMaximized): (WebCore::ChromeClient::isMinimized):

2010-04-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Changing view mode names due to specification changes
https://bugs.webkit.org/show_bug.cgi?id=37615

test: fast/media/media-feature-wgt-view-mode.html

specification: http://dev.w3.org/2006/waf/widgets-vmmf/

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::isWindowed): (WebCore::ChromeClientQt::isFullscreen): (WebCore::ChromeClientQt::isMaximized): (WebCore::ChromeClientQt::isMinimized):
  • WebCoreSupport/ChromeClientQt.h:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r57627 r57631  
     12010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        Changing view mode names due to specification changes
     6        https://bugs.webkit.org/show_bug.cgi?id=37615
     7
     8        specification: http://dev.w3.org/2006/waf/widgets-vmmf/
     9
     10        * fast/media/media-feature-wgt-view-mode.html:
     11
    1122010-04-14  Justin Schuh  <jschuh@chromium.org>
    213
  • trunk/LayoutTests/fast/media/media-feature-wgt-view-mode.html

    r57319 r57631  
    55            background-color: red;
    66        }
    7         @media (-webkit-view-mode: mini) {
     7        @media (-webkit-view-mode: minimized) {
    88            body {
    99                background-color: blue;
     
    1818    <script>
    1919        if (window.layoutTestController)
    20             layoutTestController.setViewModeMediaFeature("mini");
     20            layoutTestController.setViewModeMediaFeature("minimized");
    2121    </script>
    2222</head>
  • trunk/WebCore/ChangeLog

    r57630 r57631  
     12010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        Changing view mode names due to specification changes
     6        https://bugs.webkit.org/show_bug.cgi?id=37615
     7
     8        test: fast/media/media-feature-wgt-view-mode.html
     9
     10        specification: http://dev.w3.org/2006/waf/widgets-vmmf/
     11
     12        * css/MediaQueryEvaluator.cpp:
     13        (WebCore::view_modeMediaFeatureEval):
     14        * page/ChromeClient.h:
     15        (WebCore::ChromeClient::isWindowed):
     16        (WebCore::ChromeClient::isMaximized):
     17        (WebCore::ChromeClient::isMinimized):
     18
    1192010-04-14  Adam Barth  <abarth@webkit.org>
    220
  • trunk/WebCore/css/MediaQueryEvaluator.cpp

    r57319 r57631  
    502502        String mode = static_cast<CSSPrimitiveValue*>(value)->getStringValue();
    503503        if (ChromeClient* client = frame->page()->chrome()->client()) {
    504             if (mode == "mini" && client->isDocked())
     504            if (mode == "windowed" && client->isWindowed())
    505505                return true;
    506506            if (mode == "floating" && client->isFloating())
    507507                return true;
    508             if (mode == "application" && client->isApplication())
     508            if (mode == "fullscreen" && client->isFullscreen())
    509509                return true;
    510             if (mode == "fullscreen" && client->isFullscreen())
     510            if (mode == "maximized" && client->isMaximized())
     511                return true;
     512            if (mode == "minimized" && client->isMinimized())
    511513                return true;
    512514            return false;
  • trunk/WebCore/page/ChromeClient.h

    r56851 r57631  
    232232
    233233#if ENABLE(WIDGETS_10_SUPPORT)
    234         virtual bool isDocked() { return false; }
     234        virtual bool isWindowed() { return false; }
    235235        virtual bool isFloating() { return false; }
    236         virtual bool isApplication() { return false; }
    237236        virtual bool isFullscreen() { return false; }
     237        virtual bool isMaximized() { return false; }
     238        virtual bool isMinimized() { return false; }
    238239#endif
    239240
  • trunk/WebKit/qt/ChangeLog

    r57629 r57631  
     12010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        Changing view mode names due to specification changes
     6        https://bugs.webkit.org/show_bug.cgi?id=37615
     7
     8        test: fast/media/media-feature-wgt-view-mode.html
     9
     10        specification: http://dev.w3.org/2006/waf/widgets-vmmf/
     11
     12        * WebCoreSupport/ChromeClientQt.cpp:
     13        (WebCore::ChromeClientQt::isWindowed):
     14        (WebCore::ChromeClientQt::isFullscreen):
     15        (WebCore::ChromeClientQt::isMaximized):
     16        (WebCore::ChromeClientQt::isMinimized):
     17        * WebCoreSupport/ChromeClientQt.h:
     18
    1192010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
    220
  • trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

    r57408 r57631  
    563563
    564564#if ENABLE(WIDGETS_10_SUPPORT)
    565 bool ChromeClientQt::isDocked()
    566 {
    567     return m_webPage->d->viewMode == "mini";
     565bool ChromeClientQt::isWindowed()
     566{
     567    return m_webPage->d->viewMode == "windowed";
    568568}
    569569
     
    573573}
    574574
    575 bool ChromeClientQt::isApplication()
    576 {
    577     return m_webPage->d->viewMode == "application";
    578 }
    579 
    580575bool ChromeClientQt::isFullscreen()
    581576{
    582577    return m_webPage->d->viewMode == "fullscreen";
    583578}
    584 #endif
    585 
    586 }
     579
     580bool ChromeClientQt::isMaximized()
     581{
     582    return m_webPage->d->viewMode == "maximized";
     583}
     584
     585bool ChromeClientQt::isMinimized()
     586{
     587    return m_webPage->d->viewMode == "minimized";
     588}
     589#endif
     590
     591}
  • trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.h

    r57408 r57631  
    160160
    161161#if ENABLE(WIDGETS_10_SUPPORT)
    162         virtual bool isDocked();
     162        virtual bool isWindowed();
    163163        virtual bool isFloating();
    164         virtual bool isApplication();
    165164        virtual bool isFullscreen();
     165        virtual bool isMaximized();
     166        virtual bool isMinimized();
    166167#endif
    167168
Note: See TracChangeset for help on using the changeset viewer.