Changeset 57634 in webkit

Timestamp:

Apr 15, 2010 12:55:07 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

Add comments back to IPv4 URL parsing test
​https://bugs.webkit.org/show_bug.cgi?id=37620

I removed these comments when importing this test. The comments are
likley to be helpful to us in the future, so I've restored them.

• fast/url/script-tests/ipv4.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/url/script-tests/ipv4.js (modified) (5 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-15  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Fisher.
+
+        Add comments back to IPv4 URL parsing test
+        https://bugs.webkit.org/show_bug.cgi?id=37620
+
+        I removed these comments when importing this test.  The comments are
+        likley to be helpful to us in the future, so I've restored them.
+
+        * fast/url/script-tests/ipv4.js:
+
 2010-04-14  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/fast/url/script-tests/ipv4.js

@@ -3 +3 @@
 cases = [ 
   [".", ""],
+
+  // Regular IP addresses in different bases.
   ["192.168.0.1", "192.168.0.1"],
   ["0300.0250.00.01", "192.168.0.1"],
   ["0xC0.0Xa8.0x0.0x1", "192.168.0.1"],
+
+  // Non-IP addresses due to invalid characters.
   ["192.168.9.com", ""],
+
+  // Invalid characters for the base should be rejected.
   ["19a.168.0.1", ""],
   ["0308.0250.00.01", ""],
   ["0xCG.0xA8.0x0.0x1", ""],
+
+  // If there are not enough components, the last one should fill them out.
   ["192", "0.0.0.192"],
   ["0xC0a80001", "192.168.0.1"],
@@ -18 +26 @@
   ["0xc0.052000001", "192.168.0.1"],
   ["192.168.1", "192.168.0.1"],
+
+  // Too many components means not an IP address.
   ["192.168.0.0.1", ""],
+
+  // We allow a single trailing dot.
   ["192.168.0.1.", "192.168.0.1"],
   ["192.168.0.1. hello", ""],
   ["192.168.0.1..", ""],
+
+  // Two dots in a row means not an IP address.
   ["192.168..1", ""],
+
+  // Any numerical overflow should be marked as BROKEN.
   ["0x100.0", ""],
   ["0x100.0.0", ""],
@@ -32 +48 @@
   ["0.0x1000000", ""],
   ["0x100000000", ""],
+
+  // Repeat the previous tests, minus 1, to verify boundaries.
   ["0xFF.0", "255.0.0.0"],
   ["0xFF.0.0", "255.0.0.0"],
@@ -41 +59 @@
   ["0.0xFFFFFF", "0.255.255.255"],
   ["0xFFFFFFFF", "255.255.255.255"],
+
+  // Old trunctations tests.  They're all "BROKEN" now.
   ["276.256.0xf1a2.077777", ""],
   ["192.168.0.257", ""],
@@ -47 +67 @@
   ["0X12C0a80001", ""],
   ["276.1.2", ""],
+
+  // Spaces should be rejected.
   ["192.168.0.1 hello", ""],
+
+  // Very large numbers.
   ["0000000000000300.0x00000000000000fF.00000000000000001", "192.255.0.1"],
   ["0000000000000300.0xffffffffFFFFFFFF.3022415481470977", ""],
+
+  // A number has no length limit, but long numbers can still overflow.
   ["00000000000000000001", "0.0.0.1"],
   ["0000000000000000100000000000000001", ""],
+
+  // If a long component is non-numeric, it's a hostname, *not* a broken IP.
   ["0.0.0.000000000000000000z", ""],
   ["0.0.0.100000000000000000z", ""],
+
+  // Truncation of all zeros should still result in 0.
   ["0.00.0x.0x0", "0.0.0.0"]
 ];