Changeset 57635 in webkit

Timestamp:

Apr 15, 2010 1:07:10 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-15 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add URL scheme parsing tests
​https://bugs.webkit.org/show_bug.cgi?id=37496

I'm not super happy with how these test turned out. It's difficult to
test these cases with this methodology because most of the cases get
treated as relative URLs. I tired using the "protocol" property of the
HTMLAnchorElement, but that often caused the test case to be ignored
for reasons I don't fully understand.

• fast/url/resources/utilities.js: (setBaseURL):
  • In the course of trying various variations of this test, I wrote this function. It seemed useful, so I left it here for the benefit of future test writing.
• fast/url/scheme-expected.txt: Added.
• fast/url/scheme.html: Added.
• fast/url/script-tests/scheme.js: Added.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/url/resources/utilities.js (modified) (1 diff)
• fast/url/scheme-expected.txt (added)
• fast/url/scheme.html (added)
• fast/url/script-tests/scheme.js (added)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-15  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Maciej Stachowiak.
+
+        Add URL scheme parsing tests
+        https://bugs.webkit.org/show_bug.cgi?id=37496
+
+        I'm not super happy with how these test turned out.  It's difficult to
+        test these cases with this methodology because most of the cases get
+        treated as relative URLs.  I tired using the "protocol" property of the
+        HTMLAnchorElement, but that often caused the test case to be ignored
+        for reasons I don't fully understand.
+
+        * fast/url/resources/utilities.js:
+        (setBaseURL):
+          - In the course of trying various variations of this test, I wrote
+            this function.  It seemed useful, so I left it here for the benefit
+            of future test writing.
+        * fast/url/scheme-expected.txt: Added.
+        * fast/url/scheme.html: Added.
+        * fast/url/script-tests/scheme.js: Added.
+
 2010-04-15  Adam Barth  <abarth@webkit.org>
 

trunk/LayoutTests/fast/url/resources/utilities.js

@@ -5 +5 @@
   return a.href;
 }
+
+function setBaseURL(url)
+{
+  var base = document.createElement("base");
+  base.href = url;
+  document.documentElement.appendChild(base);
+}