Changeset 57664 in webkit

Timestamp:

Apr 15, 2010 1:07:50 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-15 Zhenyao Mo <​zmo@google.com>

Reviewed by Adam Barth.

Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
​https://bugs.webkit.org/show_bug.cgi?id=36908

• platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0. (WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/mac/GraphicsContext3DMac.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-15  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Adam Barth.
+
+        Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
+        This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
+        https://bugs.webkit.org/show_bug.cgi?id=36908
+
+        * platform/graphics/mac/GraphicsContext3DMac.cpp:
+        (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0.
+        (WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.
+
 2010-04-14  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp

@@ -83 +83 @@
 
 GraphicsContext3D::GraphicsContext3D(GraphicsContext3D::Attributes attrs)
-    : m_attrs(attrs)
+    : m_currentWidth(0)
+    , m_currentHeight(0)
+    , m_attrs(attrs)
     , m_contextObj(0)
     , m_texture(0)
@@ -341 +343 @@
         ::glBlitFramebufferEXT(0, 0, m_currentWidth, m_currentHeight, 0, 0, m_currentWidth, m_currentHeight, GL_COLOR_BUFFER_BIT, GL_LINEAR);
         ::glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, m_boundFBO);
-        ::glFinish();
-    }
+    }
+    ::glFinish();
 }