Changeset 57728 in webkit

Timestamp:

Apr 16, 2010 11:19:14 AM (14 years ago)

Author:

ukai@chromium.org

Message:

2010-04-16 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Jian Li.

[chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=37687

• src/WebURLResponse.cpp: (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebURLResponse.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>
+
+        Reviewed by Jian Li.
+
+        [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
+        https://bugs.webkit.org/show_bug.cgi?id=37687
+
+        * src/WebURLResponse.cpp:
+        (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
+
 2010-04-16  Jay Civelli  <jcivelli@chromium.org>
 

trunk/WebKit/chromium/src/WebURLResponse.cpp

@@ -166 +166 @@
 void WebURLResponse::addHTTPHeaderField(const WebString& name, const WebString& value)
 {
+    if (name.isNull() || value.isNull())
+        return;
     // FIXME: Add an addHTTPHeaderField method to ResourceResponse.
     const HTTPHeaderMap& map = m_private->m_resourceResponse->httpHeaderFields();