Changeset 57768 in webkit


Ignore:
Timestamp:
Apr 16, 2010 5:20:51 PM (14 years ago)
Author:
dumi@chromium.org
Message:

Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

  • public/WebSecurityOrigin.h:
  • src/WebDatabase.cpp:

(WebKit::WebDatabase::closeDatabaseImmediately):

  • src/WebSecurityOrigin.cpp:

(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

Location:
trunk/WebKit/chromium
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/chromium/ChangeLog

    r57767 r57768  
     12010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
     2
     3        Reviewed by Jeremy Orlow.
     4
     5        Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
     6        https://bugs.webkit.org/show_bug.cgi?id=34466
     7
     8        Changing the return type of
     9        WebSecurityOrigin::createFromDatabaseIdentifier() from
     10        WebSecurityOrigin* to WebSecurityOrigin, to make it more
     11        consistent with the other WebSecurityOrigin methods.
     12
     13        * public/WebSecurityOrigin.h:
     14        * src/WebDatabase.cpp:
     15        (WebKit::WebDatabase::closeDatabaseImmediately):
     16        * src/WebSecurityOrigin.cpp:
     17        (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
     18
    1192010-04-16  Dmitry Titov  <dimich@chromium.org>
    220
  • trunk/WebKit/chromium/public/WebSecurityOrigin.h

    r57325 r57768  
    5757    }
    5858
    59     // FIXME: This should return a WebSecurityOrigin, not a pointer to one.
    60     WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& databaseIdentifier);
     59    WEBKIT_API static WebSecurityOrigin createFromDatabaseIdentifier(const WebString& databaseIdentifier);
    6160    WEBKIT_API static WebSecurityOrigin createFromString(const WebString&);
    6261    WEBKIT_API static WebSecurityOrigin create(const WebURL&);
  • trunk/WebKit/chromium/src/WebDatabase.cpp

    r57034 r57768  
    112112{
    113113    HashSet<RefPtr<Database> > databaseHandles;
    114     PassRefPtr<SecurityOrigin> originPrp(*WebSecurityOrigin::createFromDatabaseIdentifier(originIdentifier));
     114    PassRefPtr<SecurityOrigin> originPrp(WebSecurityOrigin::createFromDatabaseIdentifier(originIdentifier));
    115115    RefPtr<SecurityOrigin> origin = originPrp;
    116116    DatabaseTracker::tracker().getOpenDatabases(origin.get(), databaseName, &databaseHandles);
  • trunk/WebKit/chromium/src/WebSecurityOrigin.cpp

    r57325 r57768  
    4545};
    4646
    47 WebSecurityOrigin* WebSecurityOrigin::createFromDatabaseIdentifier(const WebString& databaseIdentifier)
     47WebSecurityOrigin WebSecurityOrigin::createFromDatabaseIdentifier(const WebString& databaseIdentifier)
    4848{
    49     return new WebSecurityOrigin(SecurityOrigin::createFromDatabaseIdentifier(databaseIdentifier));
     49    return WebSecurityOrigin(SecurityOrigin::createFromDatabaseIdentifier(databaseIdentifier));
    5050}
    5151
Note: See TracChangeset for help on using the changeset viewer.