Changeset 57825 in webkit


Ignore:
Timestamp:
Apr 19, 2010 12:13:31 PM (14 years ago)
Author:
Adam Roben
Message:

Fix run-webkit-tests when there are spaces in the path

Fixes <http://webkit.org/b/37809>

Reviewed by Adam Barth.

  • Scripts/run-webkit-tests: Use an "indirect object" to specify the

path to the harness to exec(). According to perldoc, this usage will
prohibit perl from parsing the arguments to exec() via the shell,
which would incorrectly split paths with spaces in them, etc.

Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r57823 r57825  
     12010-04-19  Adam Roben  <aroben@apple.com>
     2
     3        Fix run-webkit-tests when there are spaces in the path
     4
     5        Fixes <http://webkit.org/b/37809>
     6
     7        Reviewed by Adam Barth.
     8
     9        * Scripts/run-webkit-tests: Use an "indirect object" to specify the
     10        path to the harness to exec(). According to perldoc, this usage will
     11        prohibit perl from parsing the arguments to exec() via the shell,
     12        which would incorrectly split paths with spaces in them, etc.
     13
    1142010-04-19  Dave Moore  <davemoore@chromium.org>
    215
  • trunk/WebKitTools/Scripts/run-webkit-tests

    r57799 r57825  
    7979
    8080my $harnessPath = sprintf("%s/%s", relativeScriptsDir(), $harnessName);
    81 exec($harnessPath, @ARGV) or die "Failed to execute $harnessPath";
     81exec $harnessPath ($harnessPath, @ARGV) or die "Failed to execute $harnessPath";
Note: See TracChangeset for help on using the changeset viewer.