Changeset 57848 in webkit


Ignore:
Timestamp:
Apr 19, 2010 3:27:16 PM (14 years ago)
Author:
Chris Fleizach
Message:

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

Test: platform/mac/accessibility/element-haspopup.html

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::ariaHasPopup):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaHasPopup): (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

  • platform/mac/accessibility/element-haspopup-expected.txt: Added.
  • platform/mac/accessibility/element-haspopup.html: Added.

2010-04-19 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

AX: aria-haspopup needs to be exposed
​https://bugs.webkit.org/show_bug.cgi?id=37808

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::hasPopup):
Location:
trunk
Files:
2 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r57842 r57848  
     12010-04-19  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        AX: aria-haspopup needs to be exposed
     6        https://bugs.webkit.org/show_bug.cgi?id=37808
     7
     8        * platform/mac/accessibility/element-haspopup-expected.txt: Added.
     9        * platform/mac/accessibility/element-haspopup.html: Added.
     10
    1112010-04-19  James Robinson  <jamesr@chromium.org>
    212

  • trunk/WebCore/ChangeLog

    r57844 r57848  
     12010-04-19  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        AX: aria-haspopup needs to be exposed
     6        https://bugs.webkit.org/show_bug.cgi?id=37808
     7
     8        Test: platform/mac/accessibility/element-haspopup.html
     9
     10        * accessibility/AccessibilityObject.h:
     11        (WebCore::AccessibilityObject::ariaHasPopup):
     12        * accessibility/AccessibilityRenderObject.cpp:
     13        (WebCore::AccessibilityRenderObject::ariaHasPopup):
     14        (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
     15        * accessibility/AccessibilityRenderObject.h:
     16        * accessibility/mac/AccessibilityObjectWrapper.mm:
     17        (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
     18        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
     19
    1202010-04-19  Anders Carlsson  <andersca@apple.com>
    221

  • trunk/WebCore/accessibility/AccessibilityObject.h

    r56882 r57848  
    348348    virtual bool supportsARIAFlowTo() const { return false; }
    349349    virtual void ariaFlowToElements(AccessibilityChildrenVector&) const { }
     350    virtual bool ariaHasPopup() const { return false; }
    350351   
    351352    // ARIA drag and drop

  • trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

    r57674 r57848  
    13311331}
    13321332   
     1333bool AccessibilityRenderObject::ariaHasPopup() const
     1334{
     1335    return elementAttributeValue(aria_haspopupAttr);
     1336}
     1337   
    13331338bool AccessibilityRenderObject::supportsARIAFlowTo() const
    13341339{
    … …  
    26822687    AccessibilityRole role = ariaRoleToWebCoreRole(ariaRole);
    26832688
    2684     if (role == ButtonRole && elementAttributeValue(aria_haspopupAttr))
     2689    if (role == ButtonRole && ariaHasPopup())
    26852690        role = PopUpButtonRole;
    26862691   

  • trunk/WebCore/accessibility/AccessibilityRenderObject.h

    r57093 r57848  
    230230    virtual bool supportsARIAFlowTo() const;
    231231    virtual void ariaFlowToElements(AccessibilityChildrenVector&) const;
     232    virtual bool ariaHasPopup() const;
    232233
    233234    virtual bool supportsARIADropping() const;

  • trunk/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm

    r53809 r57848  
    153153#endif
    154154
     155#ifndef NSAccessibilityHasPopupAttribute
     156#define NSAccessibilityHasPopupAttribute @"AXHasPopup"
     157#endif
     158
    155159#ifdef BUILDING_ON_TIGER
    156160typedef unsigned NSUInteger;
    … …  
    634638        [additional addObject:NSAccessibilityARIABusyAttribute];
    635639    }
     640   
     641    if (m_object->ariaHasPopup())
     642        [additional addObject:NSAccessibilityHasPopupAttribute];
    636643   
    637644    return additional;
    … …  
    18511858    }
    18521859   
     1860    if ([attributeName isEqualToString:NSAccessibilityHasPopupAttribute])
     1861        return [NSNumber numberWithBool:m_object->ariaHasPopup()];
     1862   
    18531863    // ARIA Live region attributes.
    18541864    if ([attributeName isEqualToString:NSAccessibilityARIALiveAttribute])

  • trunk/WebKitTools/ChangeLog

    r57847 r57848  
     12010-04-19  Chris Fleizach  <cfleizach@apple.com>
     2
     3        Reviewed by Beth Dakin.
     4
     5        AX: aria-haspopup needs to be exposed
     6        https://bugs.webkit.org/show_bug.cgi?id=37808
     7
     8        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
     9        (AccessibilityUIElement::hasPopup):
     10
    1112010-04-19  Dirk Pranke  <dpranke@chromium.org>
    212

  • trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

    r57674 r57848  
    835835bool AccessibilityUIElement::hasPopup() const
    836836{
    837     // FIXME: implement
     837    id value = [m_element accessibilityAttributeValue:@"AXHasPopup"];
     838    if ([value isKindOfClass:[NSNumber class]])
     839        return [value boolValue];
    838840    return false;
    839841}
Note: See TracChangeset for help on using the changeset viewer.