Changeset 57860 in webkit


Ignore:
Timestamp:
Apr 19, 2010 5:53:22 PM (14 years ago)
Author:
dpranke@chromium.org
Message:

2010-04-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
that can be used to test platforms other than the one you are running
on. This can be useful for checking baselines and testing code
coverage.

Note that running the code on the "wrong" port requires each
port-specific implementation to actually not require any
platform-specific python code (e.g., the chromium-win port must
test for the existence of windows functions before calling them).

https://bugs.webkit.org/show_bug.cgi?id=37782

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
Location:
trunk/WebKitTools
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r57858 r57860  
     12010-04-19  Dirk Pranke  <dpranke@chromium.org>
     2 
     3         Reviewed by Adam Barth.
     4 
     5         new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
     6         that can be used to test platforms other than the one you are running
     7         on. This can be useful for checking baselines and testing code
     8         coverage.
     9 
     10         Note that running the code on the "wrong" port requires each
     11         port-specific implementation to actually not require any
     12         platform-specific python code (e.g., the chromium-win port must
     13         test for the existence of windows functions before calling them).
     14 
     15         https://bugs.webkit.org/show_bug.cgi?id=37782
     16 
     17         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
     18         * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
     19         * Scripts/webkitpy/layout_tests/port/factory.py:
     20         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
     21
    1222010-04-19  Dirk Pranke  <dpranke@chromium.org>
    223
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py

    r57672 r57860  
    326326        if the port does not use expectations files."""
    327327        raise NotImplementedError('Port.path_to_test_expectations_file')
    328  
     328
    329329    def remove_directory(self, *path):
    330330        """Recursively removes a directory, even if it's marked read-only.
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py

    r57444 r57860  
    8888
    8989    def version(self):
     90        if not hasattr(sys, 'getwindowsversion'):
     91            return ''
    9092        winver = sys.getwindowsversion()
    9193        if winver[0] == 6 and (winver[1] == 1):
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/factory.py

    r57491 r57860  
    6060        import test
    6161        return test.TestPort(port_name, options)
    62     elif port_to_use.startswith('passing'):
    63         import passing
    64         return passing.PassingPort(port_name, options)
     62    elif port_to_use.startswith('dryrun'):
     63        import dryrun
     64        return dryrun.DryRunPort(port_name, options)
    6565    elif port_to_use.startswith('mac'):
    6666        import mac
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

    r57622 r57860  
    5757                                     'fast/html']))
    5858
     59
     60class DryrunTest(unittest.TestCase):
     61    def test_basics(self):
     62        self.assertTrue(passing_run(['--platform', 'dryrun',
     63                                     'fast/html']))
     64        self.assertTrue(passing_run(['--platform', 'dryrun-mac',
     65                                     'fast/html']))
     66        self.assertTrue(passing_run(['--platform', 'dryrun-chromium-mac',
     67                                     'fast/html']))
     68        self.assertTrue(passing_run(['--platform', 'dryrun-chromium-win',
     69                                     'fast/html']))
     70        self.assertTrue(passing_run(['--platform', 'dryrun-chromium-linux',
     71                                     'fast/html']))
     72
    5973if __name__ == '__main__':
    6074    unittest.main()
Note: See TracChangeset for help on using the changeset viewer.