Changeset 57921 in webkit

Timestamp:

Apr 20, 2010 2:32:24 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
​https://bugs.webkit.org/show_bug.cgi?id=37802

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
the method body. If after those bail out checks, no "best FocusCandidate" has been taken
yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
and exit earlier.

No behavior change, it is just a safe assignment shortcut.

• page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FocusController.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-19  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        Spatial Navigation: at @updateFocusCandidateIfCloser make an assignment shortcut when FocusCandidate is null
+        https://bugs.webkit.org/show_bug.cgi?id=37802
+
+        In updateFocusCandidateIfCloser method, we do all bail out checks in the begining of
+        the method body. If after those bail out checks, no "best FocusCandidate" has been taken
+        yet (i.e. focusCandidate.isNull() == true), we can safely take the current candidate,
+        and exit earlier.
+
+        No behavior change, it is just a safe assignment shortcut.
+
+        * page/FocusController.cpp:
+        (WebCore::updateFocusCandidateIfCloser):
+
 2010-04-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/page/FocusController.cpp

@@ -370 +370 @@
         return;
 
+    if (closest.isNull()) {
+        closest = candidate;
+        return;
+    }
+
     // If the focused node and the candadate are in the same document and current
     // closest candidate is not in an {i}frame that is preferable to get focused ...