Changeset 57947 in webkit


Ignore:
Timestamp:
Apr 20, 2010 8:31:42 PM (14 years ago)
Author:
tkent@chromium.org
Message:

2010-04-20 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Import Chromium image_diff as ImageDiff
​https://bugs.webkit.org/show_bug.cgi?id=37790

ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp: Added.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Location:
trunk/WebKitTools
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r57934 r57947  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [DRT/Chromium] Import Chromium image_diff as ImageDiff
     6        https://bugs.webkit.org/show_bug.cgi?id=37790
     7
     8        ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
     9
     10        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
     11        * DumpRenderTree/chromium/ImageDiff.cpp: Added.
     12        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
     13
    1142010-04-20  Dirk Pranke <dpranke@chromium.org>
    215

  • trunk/WebKitTools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp

    r57703 r57947  
    139139            ],
    140140        },
     141
     142        {
     143            'target_name': 'ImageDiff',
     144            'type': 'executable',
     145            'dependencies': [
     146                '<(webkit_top)/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:wtf',
     147                '<(chromium_src_dir)/gfx/gfx.gyp:gfx',
     148            ],
     149            'include_dirs': [
     150                '<(webkit_top)/JavaScriptCore',
     151                '<(chromium_src_dir)',
     152            ],
     153            'sources': [
     154                '../chromium/ImageDiff.cpp',
     155            ],
     156        },
    141157    ], # targets
    142158

  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py

    r57800 r57947  
    158158
    159159    def _path_to_image_diff(self):
     160        binary_name = 'image_diff'
    160161        if self._options.use_drt:
    161             # FIXME(tony): This should use ImageDiff.
    162             return ''
    163         return self._build_path(self._options.configuration, 'image_diff')
     162            binary_name = 'ImageDiff'
     163        return self._build_path(self._options.configuration, binary_name)
    164164
    165165    def _path_to_wdiff(self):
Note: See TracChangeset for help on using the changeset viewer.