Context Navigation

Changeset 57948 in webkit

Timestamp:

Apr 20, 2010 8:54:47 PM (14 years ago)

Author:

dbates@webkit.org

Message:

2010-04-20 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=37748

Make Sheriffbot more inspirational.

Location:

trunk/WebKitTools

Files:

-                      r57947
+                      r57948
+-04-20  Daniel Bates  <dbates@rim.com>
+        Reviewed by Eric Seidel.
+        https://bugs.webkit.org/show_bug.cgi?id=37748
+        Make Sheriffbot more inspirational.
+        * Scripts/webkitpy/common/net/bugzilla.py:
+        * Scripts/webkitpy/common/net/bugzilla_unittest.py:
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+        * Scripts/webkitpy/tool/mocktool.py:
 -04-20  Kent Tamura  <tkent@chromium.org>

-                      r57920
+                      r57948
         return self._parse_attachment_ids_request_query(self._load_query(query))
+    def _parse_quips(self, page):
+        soup = BeautifulSoup(page, convertEntities=BeautifulSoup.HTML_ENTITIES)
+        quips = soup.find(text=re.compile(r"Existing quips:")).findNext("ul").findAll("li")
+        return [unicode(quip_entry.string) for quip_entry in quips]
+    def fetch_quips(self):
+        return self._parse_quips(self._load_query("/quips.cgi?action=show"))
     # List of all r+'d bugs.
     def fetch_bug_ids_from_pending_commit_list(self):
 …
         self.queries = BugzillaQueries(self)
         self.committers = committers
+        self.cached_quips = []
         # FIXME: We should use some sort of Browser mock object when in dryrun
 …
     bug_server_regex = "https?://%s/" % re.sub('\.', '\\.', bug_server_host)
     bug_server_url = "https://%s/" % bug_server_host
+    def quips(self):
+        # We only fetch and parse the list of quips once per instantiation
+        # so that we do not burden bugs.webkit.org.
+        if not self.cached_quips and not self.dryrun:
+            self.cached_quips = self.queries.fetch_quips()
+        return self.cached_quips
     def bug_url_for_bug_id(self, bug_id, xml=False):

-                      r57869
+                      r57948
 </html>
 """
+    _sample_quip_page = u"""
+<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
+                      "http://www.w3.org/TR/html4/loose.dtd">
+<html>
+  <head>
+    <title>Bugzilla Quip System</title>
+  </head>
+  <body>
+    <h2>
+      Existing quips:
+    </h2>
+    <ul>
+        <li>Everything should be made as simple as possible, but not simpler. - Albert Einstein</li>
+        <li>Good artists copy. Great artists steal. - Pablo Picasso</li>
+        <li>\u00e7gua mole em pedra dura, tanto bate at\u008e que fura.</li>
+    </ul>
+  </body>
+</html>
+"""
     def test_request_page_parsing(self):
 …
         self.assertEquals([40511, 40722, 40723], queries._parse_attachment_ids_request_query(self._sample_request_page))
+    def test_quip_page_parsing(self):
+        queries = BugzillaQueries(None)
+        expected_quips = ["Everything should be made as simple as possible, but not simpler. - Albert Einstein", "Good artists copy. Great artists steal. - Pablo Picasso", u"\u00e7gua mole em pedra dura, tanto bate at\u008e que fura."]
+        self.assertEquals(expected_quips, queries._parse_quips(self._sample_quip_page))
     def test_load_query(self):
         queries = BugzillaQueries(Mock())

-                      r57869
+                      r57948
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import random
 import webkitpy.common.config.irc as config_irc
 …
 class Hi(IRCCommand):
     def execute(self, nick, args, tool, sheriff):
+        return '"Only you can prevent forest fires." -- Smokey the Bear'
+        quips = tool.bugs.quips()
+        quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
+        return random.choice(quips)

-                      r57869
+                      r57948
 import unittest
+import random
 from webkitpy.common.system.outputcapture import OutputCapture
 …
 class SheriffIRCBotTest(unittest.TestCase):
     def test_hi(self):
+        random.seed(23324)
         expected_stderr = 'MOCK: irc.post: "Only you can prevent forest fires." -- Smokey the Bear\n'
         OutputCapture().assert_outputs(self, run, args=["hi"], expected_stderr=expected_stderr)

-                      r57920
+                      r57948
         log("bug_description: %s" % bug_description)
+    def quips(self):
+        return ["Good artists copy. Great artists steal. - Pablo Picasso"]
     def fetch_bug(self, bug_id):
         return Bug(self.bug_cache.get(bug_id), self)

Note: See TracChangeset for help on using the changeset viewer.