Changeset 57967 in webkit
- Timestamp:
- Apr 21, 2010 5:00:29 AM (14 years ago)
- Location:
- trunk/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r57962 r57967 1 2010-04-21 Marcus Bulach <bulach@chromium.org> 2 3 Reviewed by Nate Chapin. 4 5 EventSource needs to be marked as an ActiveDomType. 6 https://bugs.webkit.org/show_bug.cgi?id=37857 7 Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled. 8 9 * bindings/scripts/CodeGeneratorV8.pm: 10 * bindings/v8/V8DOMWrapper.cpp: 11 * bindings/v8/custom/V8EventSourceConstructor.cpp: 12 (WebCore::V8EventSource::constructorCallback): 13 1 14 2010-04-21 Gustavo Sverzut Barbieri <barbieri@profusion.mobi> 2 15 -
trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm
r57936 r57967 2265 2265 # FIXME: Consider making this an .idl attribute. 2266 2266 my $type = shift; 2267 return 1 if $type eq "EventSource"; 2267 2268 return 1 if $type eq "MessagePort"; 2268 2269 return 1 if $type eq "XMLHttpRequest"; -
trunk/WebCore/bindings/v8/V8DOMWrapper.cpp
r57004 r57967 1 1 /* 2 2 * Copyright (C) 2009 Google Inc. All rights reserved. 3 * 3 * 4 4 * Redistribution and use in source and binary forms, with or without 5 5 * modification, are permitted provided that the following conditions are 6 6 * met: 7 * 7 * 8 8 * * Redistributions of source code must retain the above copyright 9 9 * notice, this list of conditions and the following disclaimer. … … 15 15 * contributors may be used to endorse or promote products derived from 16 16 * this software without specific prior written permission. 17 * 17 * 18 18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 19 19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT … … 47 47 #include "V8DOMWindow.h" 48 48 #include "V8EventListenerList.h" 49 #include "V8EventSource.h" 49 50 #include "V8HTMLCollection.h" 50 51 #include "V8HTMLDocument.h" -
trunk/WebCore/bindings/v8/custom/V8EventSourceConstructor.cpp
r56166 r57967 57 57 return throwError("EventSource constructor's associated context is not available", V8Proxy::ReferenceError); 58 58 if (args.Length() != 1) 59 return throwError(" EventSource constructor wrong number of parameters", V8Proxy::TypeError);59 return throwError("Not enough arguments", V8Proxy::SyntaxError); 60 60 61 61 ExceptionCode ec = 0; … … 63 63 64 64 RefPtr<EventSource> eventSource = EventSource::create(url, context, ec); 65 65 66 66 if (ec) 67 67 return throwError(ec);
Note: See TracChangeset
for help on using the changeset viewer.