Changeset 57967 in webkit


Ignore:
Timestamp:
Apr 21, 2010 5:00:29 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-21 Marcus Bulach <bulach@chromium.org>

Reviewed by Nate Chapin.

EventSource needs to be marked as an ActiveDomType.
https://bugs.webkit.org/show_bug.cgi?id=37857
Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/custom/V8EventSourceConstructor.cpp: (WebCore::V8EventSource::constructorCallback):
Location:
trunk/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r57962 r57967  
     12010-04-21  Marcus Bulach  <bulach@chromium.org>
     2
     3        Reviewed by Nate Chapin.
     4
     5        EventSource needs to be marked as an ActiveDomType.
     6        https://bugs.webkit.org/show_bug.cgi?id=37857
     7        Existing layout tests (fast/eventsource and http/tests/eventsource/) should pass when compiling with eventsource enabled.
     8
     9        * bindings/scripts/CodeGeneratorV8.pm:
     10        * bindings/v8/V8DOMWrapper.cpp:
     11        * bindings/v8/custom/V8EventSourceConstructor.cpp:
     12        (WebCore::V8EventSource::constructorCallback):
     13
    1142010-04-21  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
    215
  • trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r57936 r57967  
    22652265    # FIXME: Consider making this an .idl attribute.
    22662266    my $type = shift;
     2267    return 1 if $type eq "EventSource";
    22672268    return 1 if $type eq "MessagePort";
    22682269    return 1 if $type eq "XMLHttpRequest";
  • trunk/WebCore/bindings/v8/V8DOMWrapper.cpp

    r57004 r57967  
    11/*
    22 * Copyright (C) 2009 Google Inc. All rights reserved.
    3  * 
     3 *
    44 * Redistribution and use in source and binary forms, with or without
    55 * modification, are permitted provided that the following conditions are
    66 * met:
    7  * 
     7 *
    88 *     * Redistributions of source code must retain the above copyright
    99 * notice, this list of conditions and the following disclaimer.
     
    1515 * contributors may be used to endorse or promote products derived from
    1616 * this software without specific prior written permission.
    17  * 
     17 *
    1818 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
    1919 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
     
    4747#include "V8DOMWindow.h"
    4848#include "V8EventListenerList.h"
     49#include "V8EventSource.h"
    4950#include "V8HTMLCollection.h"
    5051#include "V8HTMLDocument.h"
  • trunk/WebCore/bindings/v8/custom/V8EventSourceConstructor.cpp

    r56166 r57967  
    5757        return throwError("EventSource constructor's associated context is not available", V8Proxy::ReferenceError);
    5858    if (args.Length() != 1)
    59         return throwError("EventSource constructor wrong number of parameters", V8Proxy::TypeError);
     59        return throwError("Not enough arguments", V8Proxy::SyntaxError);
    6060
    6161    ExceptionCode ec = 0;
     
    6363
    6464    RefPtr<EventSource> eventSource = EventSource::create(url, context, ec);
    65    
     65
    6666    if (ec)
    6767        return throwError(ec);
Note: See TracChangeset for help on using the changeset viewer.