Changeset 58019 in webkit

Timestamp:

Apr 21, 2010 4:11:40 PM (14 years ago)

Author:

jamesr@google.com

Message:

2010-04-21 Evan Stade <​estade@chromium.org>

Reviewed by Darin Fisher.

[chromium] Web page serializer saves tag names in upper case
​https://bugs.webkit.org/show_bug.cgi?id=37940

Simply convert all tags to lower case.

This is tested by chrome tests:

• save page browser tests
• encoding ui tests
• web page serializer test shell tests

• src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
• src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebPageSerializer.cpp (modified) (2 diffs)
• src/WebPageSerializerImpl.cpp (modified) (3 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-21  Evan Stade  <estade@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [chromium] Web page serializer saves tag names in upper case
+        https://bugs.webkit.org/show_bug.cgi?id=37940
+
+        Simply convert all tags to lower case.
+
+        This is tested by chrome tests:
+         - save page browser tests
+         - encoding ui tests
+         - web page serializer test shell tests
+
+        * src/WebPageSerializer.cpp:
+        (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
+        (WebKit::WebPageSerializer::generateBaseTagDeclaration):
+        * src/WebPageSerializerImpl.cpp:
+        (WebKit::WebPageSerializerImpl::openTagToString):
+        (WebKit::WebPageSerializerImpl::endTagToString):
+
 2010-04-20  Adam Barth  <abarth@webkit.org>
 

trunk/WebKit/chromium/src/WebPageSerializer.cpp

@@ -60 +60 @@
 WebString WebPageSerializer::generateMetaCharsetDeclaration(const WebString& charset)
 {
-    return String::format("<META http-equiv=\"Content-Type\" content=\"text/html; charset=%s\">",
+    return String::format("<meta http-equiv=\"Content-Type\" content=\"text/html; charset=%s\">",
                           charset.utf8().data());
 }
@@ -76 +76 @@
     if (!baseTarget.isEmpty())
         targetDeclaration = String::format(" target=\"%s\"", baseTarget.utf8().data());
-    return String::format("<BASE href=\".\"%s>", targetDeclaration.utf8().data());
+    return String::format("<base href=\".\"%s>", targetDeclaration.utf8().data());
 }
 

trunk/WebKit/chromium/src/WebPageSerializerImpl.cpp

@@ -307 +307 @@
         return;
     // Add open tag
-    result += "<" + element->nodeName();
+    result += "<" + element->nodeName().lower();
     // Go through all attributes and serialize them.
     const NamedNodeMap *attrMap = element->attributes(true);
@@ -375 +375 @@
     if (element->hasChildNodes() || param->hasAddedContentsBeforeEnd) {
         result += "</";
-        result += element->nodeName();
+        result += element->nodeName().lower();
         result += ">";
     } else {
@@ -386 +386 @@
                 // We need to write end tag when it is required.
                 result += "</";
-                result += element->nodeName();
+                result += element->nodeName().lower();
                 result += ">";
             }