Changeset 58037 in webkit

Timestamp:

Apr 21, 2010 6:46:34 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-21 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
​https://bugs.webkit.org/show_bug.cgi?id=34449

Implement ATK_ROLE_SEPARATOR.

• accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
• accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)
• accessibility/gtk/AccessibilityObjectAtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-21  Diego Escalante Urrelo  <descalante@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
+        WebKitGtk
+        https://bugs.webkit.org/show_bug.cgi?id=34449
+
+        Implement ATK_ROLE_SEPARATOR.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+        * accessibility/gtk/AccessibilityObjectAtk.cpp:
+        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
+
 2010-04-21  David Leong  <david.leong@nokia.com>
 

trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -2801 +2801 @@
     if (node && node->hasTagName(tableTag))
         return TableRole;
-#endif   
+#endif
+
+#if PLATFORM(GTK)
+    if (m_renderer->isHR())
+        return SplitterRole;
+#endif
 
     if (m_renderer->isBlockFlow() || (node && node->hasTagName(labelTag)))

trunk/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

@@ -41 +41 @@
     if (isMenuListPopup() || isMenuListOption())
         return IgnoreObject;
+
+    if (roleValue() == SplitterRole)
+        return IncludeObject;
 
     if (isGroup()) {