Changeset 58055 in webkit

Timestamp:

Apr 21, 2010 10:49:07 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-21 Eric Seidel <​eric@webkit.org>

Unreviewed. Attempt one more time to fix NRWT for chromium.

REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37765

I'm debugging in the blind because I don't have a chromium
build on this laptop.

• Scripts/webkitpy/layout_tests/port/chromium.py:
  • Apply the previous fix to a second caller.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/chromium.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-21  Eric Seidel  <eric@webkit.org>
+
+        Unreviewed.  Attempt one more time to fix NRWT for chromium.
+
+        REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
+        https://bugs.webkit.org/show_bug.cgi?id=37765
+
+        I'm debugging in the blind because I don't have a chromium
+        build on this laptop.
+
+        * Scripts/webkitpy/layout_tests/port/chromium.py:
+         - Apply the previous fix to a second caller.
+
 2010-04-21  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py

@@ -372 +372 @@
             try:
                 line = self._proc.stdout.readline()
+                # As far as I can tell, all output from test_shell
+                # is text output, thus we know it's all utf-8.
+                line = line.decode("utf-8")
             except IOError, e:
                 _log.error("IOError while reading: " + str(e))