Changeset 58088 in webkit


Ignore:
Timestamp:
Apr 22, 2010 5:08:29 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-22 Eric Seidel <eric@webkit.org>

Unreviewed. Script fix. Will ask dpranke to look tomorrow.

new-run-webkit-tests --verbose shows ever-increasing #EOF lines
https://bugs.webkit.org/show_bug.cgi?id=37794

The bots are seeing cases where .error is sometimes empty.
Lets make the code not crash in that case for now.

  • Scripts/webkitpy/layout_tests/port/webkit.py:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r58086 r58088  
     12010-04-22  Eric Seidel  <eric@webkit.org>
     2
     3        Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
     4
     5        new-run-webkit-tests --verbose shows ever-increasing #EOF lines
     6        https://bugs.webkit.org/show_bug.cgi?id=37794
     7
     8        The bots are seeing cases where .error is sometimes empty.
     9        Lets make the code not crash in that case for now.
     10
     11        * Scripts/webkitpy/layout_tests/port/webkit.py:
     12
    1132010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
    214
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py

    r58076 r58088  
    445445
    446446        error_lines = self._server_process.error.splitlines()
    447         error_eof = error_lines.pop()
    448         assert(error_eof == "#EOF")
     447        # FIXME: This is a hack.  It is unclear why sometimes
     448        # we do not get any error lines from the server_process
     449        # probably we are not flushing stderr.
     450        if error_lines:
     451            error_eof = error_lines.pop()
     452            assert(error_eof == "#EOF")
    449453        error = "\n".join(error_lines)
    450454        # FIXME: This seems like the wrong section of code to be doing
Note: See TracChangeset for help on using the changeset viewer.