Changeset 58097 in webkit

Timestamp:

Apr 22, 2010 8:36:42 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-22 Diego Escalante Urrelo <​descalante@igalia.com>

Reviewed by Xan Lopez.

[GTK] Mute/unmute button on <video> elements are backwards
​https://bugs.webkit.org/show_bug.cgi?id=33967

Fix mute/unmute buttons icons-action relation and explain why their
variable names and corresponding icons seem to be misleading but are
actually right. Original patch by Mike Hommey.

• platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/RenderThemeGtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-22  Diego Escalante Urrelo  <descalante@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] Mute/unmute button on <video> elements are backwards
+        https://bugs.webkit.org/show_bug.cgi?id=33967
+
+        Fix mute/unmute buttons icons-action relation and explain why their
+        variable names and corresponding icons seem to be misleading but are
+        actually right. Original patch by Mike Hommey.
+
+        * platform/gtk/RenderThemeGtk.cpp:
+        (WebCore::RenderThemeGtk::initMediaStyling):
+
 2010-04-22  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>
 

trunk/WebCore/platform/gtk/RenderThemeGtk.cpp

@@ -93 +93 @@
 
         m_fullscreenButton = Image::loadPlatformThemeIcon("gtk-fullscreen", m_mediaIconSize);
-        m_muteButton = Image::loadPlatformThemeIcon("audio-volume-muted", m_mediaIconSize);
-        m_unmuteButton = Image::loadPlatformThemeIcon("audio-volume-high", m_mediaIconSize);
+        // Note that the muteButton and unmuteButton take icons reflecting
+        // the *current* state. Hence, the unmuteButton represents the *muted*
+        // status, the muteButton represents the then current *unmuted* status.
+        m_muteButton = Image::loadPlatformThemeIcon("audio-volume-high", m_mediaIconSize);
+        m_unmuteButton = Image::loadPlatformThemeIcon("audio-volume-muted", m_mediaIconSize);
         m_playButton = Image::loadPlatformThemeIcon(reinterpret_cast<const char*>(playButtonIconName), m_mediaIconSize);
         m_pauseButton = Image::loadPlatformThemeIcon("gtk-media-pause", m_mediaIconSize).releaseRef();