Changeset 58144 in webkit


Ignore:
Timestamp:
Apr 22, 2010 8:39:56 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>

Reviewed by Darin Adler.

In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
this by changing shouldUseInputMethod to use internal methods to
check that the field is a text field that isn't a password field.

No new tests.

Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::shouldUseInputMethod):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r58143 r58144  
     12010-04-22  Ray Rischpater  <Raymond.Rischpater@Nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
     6        some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
     7        this by changing shouldUseInputMethod to use internal methods to
     8        check that the field is a text field that isn't a password field.
     9
     10        No new tests.
     11
     12        Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>
     13
     14        * html/HTMLInputElement.cpp:
     15        (WebCore::HTMLInputElement::shouldUseInputMethod):
     16
    1172010-04-22  Yaar Schnitman  <yaar@chromium.org>
    218
  • trunk/WebCore/html/HTMLInputElement.cpp

    r58057 r58144  
    730730bool HTMLInputElement::shouldUseInputMethod() const
    731731{
    732     return m_type == TEXT || m_type == SEARCH || m_type == ISINDEX;
     732    // The reason IME's are disabled for the password field is because IMEs
     733    // can access the underlying password and display it in clear text --
     734    // e.g. you can use it to access the stored password for any site
     735    // with only trivial effort.
     736    return isTextField() && inputType() != PASSWORD;
    733737}
    734738
Note: See TracChangeset for help on using the changeset viewer.