Changeset 58153 in webkit


Ignore:
Timestamp:
Apr 23, 2010 12:04:31 AM (14 years ago)
Author:
tony@chromium.org
Message:

2010-04-22 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
​https://bugs.webkit.org/show_bug.cgi?id=37950

  • editing/text-iterator/rtl-selection-crash-expected.txt: Added.
  • editing/text-iterator/rtl-selection-crash.html: Added.

2010-04-22 Tony Chang <​tony@chromium.org>

Reviewed by Dan Bernstein.

Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
​https://bugs.webkit.org/show_bug.cgi?id=37950

Test: editing/text-iterator/rtl-selection-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r58152 r58153  
     12010-04-22  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
     6        https://bugs.webkit.org/show_bug.cgi?id=37950
     7
     8        * editing/text-iterator/rtl-selection-crash-expected.txt: Added.
     9        * editing/text-iterator/rtl-selection-crash.html: Added.
     10
    1112010-04-22  Maciej Stachowiak  <mjs@apple.com>
    212

  • trunk/WebCore/ChangeLog

    r58151 r58153  
     12010-04-22  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
     6        https://bugs.webkit.org/show_bug.cgi?id=37950
     7
     8        Test: editing/text-iterator/rtl-selection-crash.html
     9
     10        * editing/TextIterator.cpp:
     11        (WebCore::TextIterator::handleTextNode):
     12
    1132010-04-22  Maciej Stachowiak  <mjs@apple.com>
    214

  • trunk/WebCore/editing/TextIterator.cpp

    r58149 r58153  
    475475    }
    476476   
    477     m_textBox = renderer->containsReversedText() ? m_sortedTextBoxes[0] : renderer->firstTextBox();
     477    m_textBox = renderer->containsReversedText() ? (m_sortedTextBoxes.isEmpty() ? 0 : m_sortedTextBoxes[0]) : renderer->firstTextBox();
    478478    handleTextBox();
    479479    return true;
Note: See TracChangeset for help on using the changeset viewer.