Changeset 58163 in webkit

Timestamp:

Apr 23, 2010 6:05:03 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-23 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
​https://bugs.webkit.org/show_bug.cgi?id=37988

• inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/AuditRules.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-23  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
+        https://bugs.webkit.org/show_bug.cgi?id=37988
+
+        * inspector/front-end/AuditRules.js:
+        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
+
 2010-04-23  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/WebCore/inspector/front-end/AuditRules.js

@@ -648 +648 @@
             const node = WebInspector.domAgent.nodeForId(imageId);
             var src = node.getAttribute("src");
-            for (var frameOwnerCandidate = node; frameOwnerCandidate; frameOwnerCandidate = frameOwnerCandidate.parentNode) {
-                if (frameOwnerCandidate.documentURL) {
-                    var completeSrc = WebInspector.completeURL(frameOwnerCandidate.documentURL, src);
-                    break;
+            if (!WebInspector.URLRegExp.test(src)) {
+                for (var frameOwnerCandidate = node; frameOwnerCandidate; frameOwnerCandidate = frameOwnerCandidate.parentNode) {
+                    if (frameOwnerCandidate.documentURL) {
+                        var completeSrc = WebInspector.completeURL(frameOwnerCandidate.documentURL, src);
+                        break;
+                    }
                 }
             }