Changeset 58243 in webkit

Timestamp:

Apr 26, 2010 3:05:10 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-26 Zoltan Herczeg <​zherczeg@webkit.org>

Reviewed by Dirk Schulze.

Call setStrokeStyle in applyStrokeStyleToContext
​https://bugs.webkit.org/show_bug.cgi?id=37849

Not all platforms set the stroke style to solid if they
get an empty line dash array. Some just ignore the operation.

• rendering/SVGRenderSupport.cpp: (WebCore::applyStrokeStyleToContext):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/SVGRenderSupport.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-26  Zoltan Herczeg  <zherczeg@webkit.org>
+
+        Reviewed by Dirk Schulze.
+
+        Call setStrokeStyle in applyStrokeStyleToContext
+        https://bugs.webkit.org/show_bug.cgi?id=37849
+
+        Not all platforms set the stroke style to solid if they
+        get an empty line dash array. Some just ignore the operation.
+
+        * rendering/SVGRenderSupport.cpp:
+        (WebCore::applyStrokeStyleToContext):
+
 2010-04-23  Ilya Tikhonovsky  <loislo@chromium.org>
 

trunk/WebCore/rendering/SVGRenderSupport.cpp

@@ -400 +400 @@
     const DashArray& dashes = dashArrayFromRenderingStyle(object->style(), object->document()->documentElement()->renderStyle());
     float dashOffset = SVGRenderStyle::cssPrimitiveToLength(object, style->svgStyle()->strokeDashOffset(), 0.0f);
-    context->setLineDash(dashes, dashOffset);
+    if (dashes.isEmpty())
+        context->setStrokeStyle(SolidStroke);
+    else
+        context->setLineDash(dashes, dashOffset);
 }