Changeset 58248 in webkit

Timestamp:

Apr 26, 2010 5:28:15 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-26 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak in the QScriptString.

QScriptStringPrivate's constructor shouldn't call JSStringRetain as
QScriptConverter implicitly pass a JSStringRef ownership.

[Qt] QScriptStringPrivate c'tor problem
​https://bugs.webkit.org/show_bug.cgi?id=38110

• qt/api/qscriptstring_p.h: (QScriptStringPrivate::QScriptStringPrivate):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• qt/api/qscriptstring_p.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-04-26  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Fix a memory leak in the QScriptString.
+
+        QScriptStringPrivate's constructor shouldn't call JSStringRetain as
+        QScriptConverter implicitly pass a JSStringRef ownership.
+
+        [Qt] QScriptStringPrivate c'tor problem
+        https://bugs.webkit.org/show_bug.cgi?id=38110
+
+        * qt/api/qscriptstring_p.h:
+        (QScriptStringPrivate::QScriptStringPrivate):
+
 2010-04-24  Darin Adler  <darin@apple.com>
 

trunk/JavaScriptCore/qt/api/qscriptstring_p.h

@@ -57 +57 @@
 
 QScriptStringPrivate::QScriptStringPrivate(const QString& qtstring)
-    : m_string(JSStringRetain(QScriptConverter::toString(qtstring)))
+    : m_string(QScriptConverter::toString(qtstring))
 {}