Changeset 58264 in webkit

Timestamp:

Apr 26, 2010 2:43:52 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-26 Yongjun Zhang <​yongjun_zhang@apple.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=38128
Don't add empty credential to CredentialStorage.

An empty credential is currently regarded as a invalid login because it means a missing value in
protectionSpaceToCredentialMap. This change makes it consistent with current WebCore's behavior
by ignoring empty credentials.

No new tests added since this only affects credential entered by user from credential dialog,
which is not testable in DRT.

• platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedCredential):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/ResourceHandleMac.mm (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-26  Yongjun Zhang  <yongjun_zhang@apple.com>
+
+        Reviewed by Alexey Proskuryakov.
+        
+        https://bugs.webkit.org/show_bug.cgi?id=38128
+        Don't add empty credential to CredentialStorage.
+        
+        An empty credential is currently regarded as a invalid login because it means a missing value in 
+        protectionSpaceToCredentialMap.  This change makes it consistent with current WebCore's behavior
+        by ignoring empty credentials.
+        
+        No new tests added since this only affects credential entered by user from credential dialog,
+        which is not testable in DRT.
+
+        * platform/network/mac/ResourceHandleMac.mm:
+        (WebCore::ResourceHandle::receivedCredential):
+
 2010-04-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 

trunk/WebCore/platform/network/mac/ResourceHandleMac.mm

@@ -573 +573 @@
     if (challenge != d->m_currentWebChallenge)
         return;
+    
+    if (credential.isEmpty()) {
+        receivedRequestToContinueWithoutCredential(challenge);
+        return;
+    }
 
 #ifdef BUILDING_ON_TIGER