Changeset 58265 in webkit

Timestamp:

Apr 26, 2010 2:52:40 PM (14 years ago)

Author:

ojan@chromium.org

Message:

2010-04-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

complete rietveld bugzilla integration
​https://bugs.webkit.org/show_bug.cgi?id=38021

Makes --fancy-review the default. All this means is that the patch will
be uploaded to rietveld in addition to bugs.webkit.org.

• Scripts/webkitpy/tool/steps/options.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/steps/options.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-26  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        complete rietveld bugzilla integration
+        https://bugs.webkit.org/show_bug.cgi?id=38021
+
+        Makes --fancy-review the default. All this means is that the patch will
+        be uploaded to rietveld in addition to bugs.webkit.org. 
+
+        * Scripts/webkitpy/tool/steps/options.py:
+
 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/tool/steps/options.py

@@ -41 +41 @@
     description = make_option("-m", "--description", action="store", type="string", dest="description", help="Description string for the attachment (default: \"patch\")")
     email = make_option("--email", action="store", type="string", dest="email", help="Email address to use in ChangeLogs.")
-    fancy_review = make_option("--fancy-review", action="store_true", dest="fancy_review", default=False, help="(Experimental) Upload the patch to Rietveld code review tool.")
+    fancy_review = make_option("--no-fancy-review", action="store_false", dest="fancy_review", default=True, help="Do not upload the patch to Rietveld code review tool.")
     force_clean = make_option("--force-clean", action="store_true", dest="force_clean", default=False, help="Clean working directory before applying patches (removes local changes and commits)")
 # FIXME: Make commit ranges treat each commit separately instead of squashing them into one.