Changeset 58323 in webkit

Timestamp:

Apr 27, 2010 12:45:30 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-27 Ben Murdoch <​benm@google.com>

Reviewed by Simon Hausmann.

The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
​https://bugs.webkit.org/show_bug.cgi?id=37609

No new tests required, only updating documentation.

• page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling

the TouchStationary state as a result of discussions in bug 37609.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/EventHandler.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-27  Ben Murdoch  <benm@google.com>
+
+        Reviewed by Simon Hausmann.
+
+        The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
+        https://bugs.webkit.org/show_bug.cgi?id=37609
+
+        No new tests required, only updating documentation.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling
+            the TouchStationary state as a result of discussions in bug 37609.
+
 2010-04-27  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/page/EventHandler.cpp

@@ -2749 +2749 @@
 
         // Now build up the correct list for changedTouches.
+        // Note that  any touches that are in the TouchStationary state (e.g. if
+        // the user had several points touched but did not move them all) should
+        // only be present in the touches list. They may also be added to the
+        // targetTouches list later, but should never be in the changedTouches
+        // list so we do not handle them explicitly here.
+        // See https://bugs.webkit.org/show_bug.cgi?id=37609 for further discussion
+        // about the TouchStationary state.
         if (point.state() == PlatformTouchPoint::TouchReleased)
             releasedTouches->append(touch);