Changeset 58358 in webkit


Ignore:
Timestamp:
Apr 27, 2010 5:28:28 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
​https://bugs.webkit.org/show_bug.cgi?id=38178

  • public/WebFrameClient.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

2010-04-27 Darin Fisher <​darin@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove deprecated form of didChangeLocationWithinPage
​https://bugs.webkit.org/show_bug.cgi?id=38178

Switch over to implementing didNavigateWithinPage.

  • DumpRenderTree/chromium/WebViewHost.cpp: (TestWebViewDelegate::didNavigateWithinPage): (WebViewHost::didChangeLocationWithinPage):
  • DumpRenderTree/chromium/WebViewHost.h:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/chromium/ChangeLog

    r58341 r58358  
     12010-04-27  Darin Fisher  <darin@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [Chromium] Remove deprecated form of didChangeLocationWithinPage
     6        https://bugs.webkit.org/show_bug.cgi?id=38178
     7
     8        * public/WebFrameClient.h:
     9        * src/FrameLoaderClientImpl.cpp:
     10        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
     11
    1122010-04-27  Evan Martin  <evan@chromium.org>
    213

  • trunk/WebKit/chromium/public/WebFrameClient.h

    r58111 r58358  
    215215    // The navigation resulted in scrolling the page to a named anchor instead
    216216    // of downloading a new document.
    217     // FIXME: The isNewNavigation parameter is DEPRECATED.
    218     virtual void didChangeLocationWithinPage(WebFrame*, bool isNewNavigation) { }
    219217    virtual void didChangeLocationWithinPage(WebFrame*) { }
    220218

  • trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp

    r58111 r58358  
    629629    bool isNewNavigation;
    630630    webView->didCommitLoad(&isNewNavigation);
    631     if (m_webFrame->client()) {
     631    if (m_webFrame->client())
    632632        m_webFrame->client()->didNavigateWithinPage(m_webFrame, isNewNavigation);
    633 
    634         // FIXME: Remove this notification once it is no longer consumed downstream.
    635         if (isHashChange)
    636             m_webFrame->client()->didChangeLocationWithinPage(m_webFrame, isNewNavigation);
    637     }
    638633
    639634    // Generate didStopLoading if loader is completed.

  • trunk/WebKitTools/ChangeLog

    r58354 r58358  
     12010-04-27  Darin Fisher  <darin@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [Chromium] Remove deprecated form of didChangeLocationWithinPage
     6        https://bugs.webkit.org/show_bug.cgi?id=38178
     7
     8        Switch over to implementing didNavigateWithinPage.
     9
     10        * DumpRenderTree/chromium/WebViewHost.cpp:
     11        (TestWebViewDelegate::didNavigateWithinPage):
     12        (WebViewHost::didChangeLocationWithinPage):
     13        * DumpRenderTree/chromium/WebViewHost.h:
     14
    1152010-04-27  Evan Martin  <evan@chromium.org>
    216

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp

    r57981 r58358  
    841841}
    842842
    843 void WebViewHost::didChangeLocationWithinPage(WebFrame* frame, bool isNewNavigation)
     843void WebViewHost::didNavigateWithinPage(WebFrame* frame, bool isNewNavigation)
    844844{
    845845    frame->dataSource()->setExtraData(m_pendingExtraData.release());
     846
     847    updateForCommittedLoad(frame, isNewNavigation);
     848}
     849
     850void WebViewHost::didChangeLocationWithinPage(WebFrame* frame)
     851{
    846852    if (m_shell->shouldDumpFrameLoadCallbacks()) {
    847853        printFrameDescription(frame);
    848854        fputs(" - didChangeLocationWithinPageForFrame\n", stdout);
    849855    }
    850     updateForCommittedLoad(frame, isNewNavigation);
    851856}
    852857

  • trunk/WebKitTools/DumpRenderTree/chromium/WebViewHost.h

    r57981 r58358  
    164164    virtual void didFailLoad(WebKit::WebFrame*, const WebKit::WebURLError&);
    165165    virtual void didFinishLoad(WebKit::WebFrame*);
    166     virtual void didChangeLocationWithinPage(WebKit::WebFrame*, bool isNewNavigation);
     166    virtual void didNavigateWithinPage(WebKit::WebFrame*, bool isNewNavigation);
     167    virtual void didChangeLocationWithinPage(WebKit::WebFrame*);
    167168    virtual void assignIdentifierToRequest(WebKit::WebFrame*, unsigned identifier, const WebKit::WebURLRequest&);
    168169    virtual void willSendRequest(WebKit::WebFrame*, unsigned identifier, WebKit::WebURLRequest&, const WebKit::WebURLResponse&);
Note: See TracChangeset for help on using the changeset viewer.