Changeset 58543 in webkit


Ignore:
Timestamp:
Apr 29, 2010 3:20:45 PM (14 years ago)
Author:
mitz@apple.com
Message:

<rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
https://bugs.webkit.org/show_bug.cgi?id=38350

Reviewed by Simon Fraser.

WebCore:

Tests: media/audio-only-video-intrinsic-size.html

media/media-document-audio-size.html

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::RenderVideo): Until metadata is available, ignore the natural size
reported by the player.
(WebCore::RenderVideo::videoSizeChanged): Respect a natural size of zero if reported by the
player, except in standalone media documents.

LayoutTests:

  • media/audio-only-video-intrinsic-size-expected.txt: Added.
  • media/audio-only-video-intrinsic-size.html: Added.
  • media/media-document-audio-size-expected.txt: Added.
  • media/media-document-audio-size.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r58541 r58543  
     12010-04-29  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
     6        https://bugs.webkit.org/show_bug.cgi?id=38350
     7
     8        * media/audio-only-video-intrinsic-size-expected.txt: Added.
     9        * media/audio-only-video-intrinsic-size.html: Added.
     10        * media/media-document-audio-size-expected.txt: Added.
     11        * media/media-document-audio-size.html: Added.
     12
    1132010-04-29  Yaar Schnitman  <yaar@chromium.org>
    214
  • trunk/WebCore/ChangeLog

    r58542 r58543  
     12010-04-29  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Simon Fraser.
     4
     5        <rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
     6        https://bugs.webkit.org/show_bug.cgi?id=38350
     7
     8        Tests: media/audio-only-video-intrinsic-size.html
     9               media/media-document-audio-size.html
     10
     11        * rendering/RenderVideo.cpp:
     12        (WebCore::RenderVideo::RenderVideo): Until metadata is available, ignore the natural size
     13        reported by the player.
     14        (WebCore::RenderVideo::videoSizeChanged): Respect a natural size of zero if reported by the
     15        player, except in standalone media documents.
     16
    1172010-04-29  Anders Carlsson  <andersca@apple.com>
    218
     
    4017140187
    4017240188        * bindings/js/ScriptCallStack.cpp:
    40173         (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.
     40189        (WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still available so pass it to the ScriptCallFrame being constructed.
    4017440190
    40175401912010-02-01  Dirk Schulze  <krit@webkit.org>
  • trunk/WebCore/rendering/RenderVideo.cpp

    r56650 r58543  
    5151    : RenderMedia(video)
    5252{
    53     if (video->player())
     53    if (video->player() && video->readyState() >= HTMLVideoElement::HAVE_METADATA)
    5454        setIntrinsicSize(video->player()->naturalSize());
    5555    else {
     
    102102        return;
    103103    IntSize size = player()->naturalSize();
    104     if (!size.isEmpty() && size != intrinsicSize()) {
     104    if (size.isEmpty()) {
     105        if (node()->ownerDocument() && node()->ownerDocument()->isMediaDocument())
     106            return;
     107    }
     108    if (size != intrinsicSize()) {
    105109        setIntrinsicSize(size);
    106110        setPrefWidthsDirty(true);
Note: See TracChangeset for help on using the changeset viewer.