Changeset 58672 in webkit

Timestamp:

May 3, 2010 7:10:11 AM (14 years ago)

Author:

vestbo@webkit.org

Message:

[Qt] Fix rendering of <button> elements on Mac OS X

Reviewed by Simon Hausmann.

The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/qt/RenderThemeQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-05-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Fix rendering of <button> elements on Mac OS X
+
+        The <button> element has ButtonPart appearance, not PushButton part,
+        so we have to include ButtonPart when we decide if we should draw the
+        button as raised on Mac OS X.
+
+        https://bugs.webkit.org/show_bug.cgi?id=38458
+
+        * platform/qt/RenderThemeQt.cpp:
+        (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
+
 2010-04-30  Philippe Normand  <pnormand@igalia.com>
 

trunk/WebCore/platform/qt/RenderThemeQt.cpp

@@ -969 +969 @@
         if (isPressed(o))
             option.state |= QStyle::State_Sunken;
-        else if (result == PushButtonPart)
+        else if (result == PushButtonPart || result == ButtonPart)
             option.state |= QStyle::State_Raised;
         break;