Changeset 58686 in webkit


Ignore:
Timestamp:
May 3, 2010 11:12:40 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareSubmit): Call frame loader's dispatchWillSendSubmitEvent
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent): New empty method

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • efl/WebCoreSupport/FrameLoaderClientEfl.h: (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • public/WebFrameClient.h: (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
  • src/FrameLoaderClientImpl.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientGtk.h: (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientHaiku.h: (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/WebFrameLoaderClient.h: (WebFrameLoaderClient::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebFrame.h:

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebKitSupport/FrameLoaderClientWx.h: (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):

2010-05-03 Jens Alfke <​snej@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=38397

No tests (functionality is exposed only through native WebKit API.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Location:
trunk
Files:
24 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r58685 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * html/HTMLFormElement.cpp:
     11        (WebCore::HTMLFormElement::prepareSubmit):  Call frame loader's dispatchWillSendSubmitEvent
     12        * loader/EmptyClients.h:
     13        * loader/FrameLoaderClient.h:
     14        (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent):  New empty method
     15
    1162010-05-03  Philippe Normand  <pnormand@igalia.com>
    217

  • trunk/WebCore/html/HTMLFormElement.cpp

    r58520 r58686  
    3939#include "Frame.h"
    4040#include "FrameLoader.h"
     41#include "FrameLoaderClient.h"
    4142#include "HTMLDocument.h"
    4243#include "HTMLFormCollection.h"
    … …  
    292293    if (!validateInteractively(event))
    293294        return false;
     295
     296    frame->loader()->client()->dispatchWillSendSubmitEvent(this);
    294297
    295298    if (dispatchEvent(Event::create(eventNames().submitEvent, true, true)) && !m_doingsubmit)

  • trunk/WebCore/loader/EmptyClients.h

    r58442 r58686  
    235235    virtual void dispatchUnableToImplementPolicy(const ResourceError&) { }
    236236
     237    virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
    237238    virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>) { }
    238239

  • trunk/WebCore/loader/FrameLoaderClient.h

    r58442 r58686  
    5555    class HistoryItem;
    5656    class HTMLAppletElement;
     57    class HTMLFormElement;
    5758    class HTMLFrameOwnerElement;
    5859#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
    … …  
    150151        virtual void dispatchUnableToImplementPolicy(const ResourceError&) = 0;
    151152
     153        virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) = 0;
    152154        virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>) = 0;
    153155

  • trunk/WebKit/ChangeLog

    r58124 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * efl/WebCoreSupport/FrameLoaderClientEfl.h:
     11        (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):
     12
    1132010-04-22  Leandro Pereira  <leandro@profusion.mobi>
    214

  • trunk/WebKit/chromium/ChangeLog

    r58647 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * public/WebFrameClient.h:
     11        (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
     12        * src/FrameLoaderClientImpl.cpp:
     13        (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
     14        * src/FrameLoaderClientImpl.h:
     15
    1162010-05-02  Michael Nordman  <michaeln@google.com>
    217

  • trunk/WebKit/chromium/public/WebFrameClient.h

    r58362 r58686  
    139139    // Navigational notifications ------------------------------------------
    140140
     141    // A form submission has been requested, but the page's submit event handler
     142    // hasn't yet had a chance to run (and possibly alter/interrupt the submit.)
     143    virtual void willSendSubmitEvent(WebFrame*, const WebFormElement&) { }
     144
    141145    // A form submission is about to occur.
    142146    virtual void willSubmitForm(WebFrame*, const WebFormElement&) { }

  • trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp

    r58362 r58686  
    953953}
    954954
     955void FrameLoaderClientImpl::dispatchWillSendSubmitEvent(HTMLFormElement* form)
     956{
     957    if (m_webFrame->client())
     958        m_webFrame->client()->willSendSubmitEvent(m_webFrame, WebFormElement(form));
     959}
     960
    955961void FrameLoaderClientImpl::dispatchWillSubmitForm(FramePolicyFunction function,
    956962    PassRefPtr<FormState> formState)

  • trunk/WebKit/chromium/src/FrameLoaderClientImpl.h

    r58111 r58686  
    118118    virtual void cancelPolicyCheck();
    119119    virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
     120    virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*);
    120121    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>);
    121122    virtual void dispatchDidLoadMainResource(WebCore::DocumentLoader*);

  • trunk/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h

    r57970 r58686  
    122122    virtual void dispatchUnableToImplementPolicy(const ResourceError&);
    123123
     124    virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
    124125    virtual void dispatchWillSubmitForm(FramePolicyFunction, WTF::PassRefPtr<FormState>);
    125126

  • trunk/WebKit/gtk/ChangeLog

    r58634 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebCoreSupport/FrameLoaderClientGtk.h:
     11        (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):
     12
    1132010-05-01  Xan Lopez  <xlopez@igalia.com>
    214

  • trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h

    r58111 r58686  
    102102        virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
    103103
     104        virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) { }
    104105        virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, WTF::PassRefPtr<WebCore::FormState>);
    105106

  • trunk/WebKit/haiku/ChangeLog

    r57927 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebCoreSupport/FrameLoaderClientHaiku.h:
     11        (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):
     12
    1132010-04-20  Adam Barth  <abarth@webkit.org>
    214

  • trunk/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h

    r57210 r58686  
    113113        virtual void cancelPolicyCheck();
    114114
     115        virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
    115116        virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
    116117

  • trunk/WebKit/mac/ChangeLog

    r58623 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebCoreSupport/WebFrameLoaderClient.h:
     11        (WebFrameLoaderClient::dispatchWillSendSubmitEvent):
     12
    1132010-04-30  Simon Fraser  <simon.fraser@apple.com>
    214

  • trunk/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h

    r58442 r58686  
    126126    virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
    127127
     128    virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) { }
    128129    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>);
    129130

  • trunk/WebKit/qt/ChangeLog

    r58670 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebCoreSupport/FrameLoaderClientQt.h:
     11        (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):
     12
    1132010-05-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
    214

  • trunk/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h

    r58111 r58686  
    129129        virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
    130130
     131        virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
    131132        virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
    132133

  • trunk/WebKit/win/ChangeLog

    r58625 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebFrame.h:
     11
    1122010-04-30  Jon Honeycutt  <jhoneycutt@apple.com>
    213

  • trunk/WebKit/win/WebFrame.h

    r58111 r58686  
    287287    virtual void detachedFromParent3();
    288288    virtual void cancelPolicyCheck();
     289    virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) { }
    289290    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>);
    290291    virtual void revertToProvisionalState(WebCore::DocumentLoader*);

  • trunk/WebKit/wx/ChangeLog

    r58266 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebKitSupport/FrameLoaderClientWx.h:
     11        (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):
     12
    1132010-04-25  Sam Weinig  <sam@webkit.org>
    214

  • trunk/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h

    r57863 r58686  
    114114        virtual void cancelPolicyCheck();
    115115
     116        virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) { }
    116117        virtual void dispatchWillSubmitForm(FramePolicyFunction, PassRefPtr<FormState>);
    117118

  • trunk/WebKit2/ChangeLog

    r58684 r58686  
     12010-05-03  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Darin Fisher.
     4
     5        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
     6        https://bugs.webkit.org/show_bug.cgi?id=38397
     7
     8        No tests (functionality is exposed only through native WebKit API.)
     9
     10        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
     11        (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
     12
    1132010-05-01  Sam Weinig  <sam@webkit.org>
    214

  • trunk/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

    r58465 r58686  
    104104    virtual void dispatchUnableToImplementPolicy(const WebCore::ResourceError&);
    105105   
     106    virtual void dispatchWillSendSubmitEvent(WebCore::HTMLFormElement*) { }
    106107    virtual void dispatchWillSubmitForm(WebCore::FramePolicyFunction, PassRefPtr<WebCore::FormState>);
    107108   
Note: See TracChangeset for help on using the changeset viewer.