Changeset 58744 in webkit


Ignore:
Timestamp:
May 4, 2010 2:15:05 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-05-04 Tucker Jay <​jay.tucker@nokia.com>

Reviewed by Holger Freyther.

Animated GIF images does not animate 10x as expected by default.
​https://bugs.webkit.org/show_bug.cgi?id=36818

Added test case to existing manual test to test the
fixed functionality.

  • manual-tests/qt/qt-10loop-anim.gif: Added.
  • manual-tests/qt/qt-gif-test.html:
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::repetitionCount):
Location:
trunk/WebCore
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r58743 r58744  
     12010-05-04  Tucker Jay  <jay.tucker@nokia.com>
     2
     3        Reviewed by Holger Freyther.
     4
     5        Animated GIF images does not animate 10x as expected by default.
     6        https://bugs.webkit.org/show_bug.cgi?id=36818
     7
     8        Added test case to existing manual test to test the
     9        fixed functionality.
     10
     11        * manual-tests/qt/qt-10loop-anim.gif: Added.
     12        * manual-tests/qt/qt-gif-test.html:
     13        * platform/graphics/qt/ImageDecoderQt.cpp:
     14        (WebCore::ImageDecoderQt::repetitionCount):
     15
    1162010-05-04  Dirk Schulze  <krit@webkit.org>
    217

  • trunk/WebCore/manual-tests/qt/qt-gif-test.html

    r55774 r58744  
    33<div>
    44    <img src="qt-anim.gif">
    5     <p>This should animate</p>
     5    <p>This should animate.</p>
    66</div>
    77<div>
    88    <img src="qt-noanim.gif">
    9     <p>This should not animate and you should see a cross</p>
     9    <p>This should not animate and you should see a cross.</p>
     10</div
     11<div>
     12    <img src="qt-10loop-anim.gif">
     13    <p>This animation should loop 10 times.</p>
    1014</div
    1115</body>

  • trunk/WebCore/platform/graphics/qt/ImageDecoderQt.cpp

    r57979 r58744  
    124124        //  -1   |     0              | infinite animation
    125125        //   0   | cAnimationLoopOnce | show every frame once
    126         //   n   |     n              | no idea if that is supported
     126        //   n   |     n+1            | Qt returns the # of iterations - 1
    127127        //  n/a  | cAnimationNone     | show only the first frame
    128128        if (m_repetitionCount == -1)
    … …  
    130130        else if (m_repetitionCount == 0)
    131131            m_repetitionCount = cAnimationLoopOnce;
     132        else
     133            ++m_repetitionCount;
    132134    }
    133135
Note: See TracChangeset for help on using the changeset viewer.